Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize Dockerfiles and improve image generation process #9

Closed
fedorov opened this issue Sep 20, 2023 · 1 comment · Fixed by #26
Closed

Reorganize Dockerfiles and improve image generation process #9

fedorov opened this issue Sep 20, 2023 · 1 comment · Fixed by #26
Assignees

Comments

@fedorov
Copy link
Member

fedorov commented Sep 20, 2023

Currently, all of the images from (functionally) different dockerfiles are deposited into the same Docker Hub repository. This can be confusing and may not be the best practice. We should do the following:

  • reorganize the docker files to name them more intuitively and include description of the functionality
  • set up automated docker image build process (probably, using GitHub Actions) and deposit each functionally distinctive image into an intuitively named DockerHub repo, tagged with the GitHub hash as a version

We also considered revisiting how docker images are generated, and reducing the number of docker images by installing task-specific packages as part of the notebook. This would definitely simplify maintenance and the process of integrating new tools by the users, but it will definitely result in a significant performance cost installing packages at runtime, so we discarded this idea.

@vkt1414
Copy link
Collaborator

vkt1414 commented Sep 21, 2023

@fedorov I was able to figure out the CI/CD process for docker images.

There are five dockerfiles in our repo, and I came up with these names:

task1 ="imagingdatacommons/download_convert"
task2 ="imagingdatacommons/inference_totalseg"
task3 ="imagingdatacommons/radiomics"

tasks1and2 ="imagingdatacommons/download_convert_inference_totalseg"
end_to_end ="imagingdatacommons/download_convert_inference_totalseg_radiomics"

Please let me know if they look ok. I'll reorganize the directory structure and update references whereever applicable

@vkt1414 vkt1414 self-assigned this Sep 28, 2023
fedorov added a commit that referenced this issue Oct 18, 2023
Resolve Issue #9 (Reorganizing dockerfiles and docker images CI/CD)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants