-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify the manifest organization and data access #45
Comments
I was able to pass the list of one way to make this work is, we continue to use manifests for SB-CGC, but the papermill commands for Terra and SB-CGC will be different if we use list of SeriesInstanceUIDs what do you think? |
I am not sure I understand - I thought we keep using CSV, just change its content. I thought about this issue as about simplifying manifest - not getting rid of it. |
I don't have the experience to weigh in, I am afraid .... But we should make sure IDC version is included as a column! |
I forgot about the |
Yes, it's ok - at least for now |
I realized I could use the same papermill command but use an additional step for SB-CGC, which is just reading the manifest and passing the list of seriesInstanceUIDs to the papermill command. |
As discussed today, we should be able to parameterize execution of the workflow with just the list of
SeriesInstanceUID
s and the version of IDC that should be used. We should also switch to usingidc-index
for resolving to series URLs and downloading the files.This is dependent on update of
idc-index
to IDC v17, and other updates which I am working on in ImagingDataCommons/idc-index#23.The text was updated successfully, but these errors were encountered: