-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle errors during type conversions #9
Comments
Hi @ImVexed if you need help with this one, I can try my hands on this. |
That'd be appreciated @goku321 I'm tied up until next weekend but should be able to review any pull request related to this in the meantime. |
Great @ImVexed ! I'll start getting familiar with the code. |
@goku321 Any progress on this? |
Hi @ImVexed I moved to a different city few days back and just getting settled here so couldn't make progress on this. If it's okay, I can work on it this coming weekend. Thanks for your patience. |
@goku321 Absolutely! No worries. Was mainly just a reminder in case it fell off your radar and others were interested in picking it up. |
That code won't work the way you're thinking. I'm more concerned with places like https://github.com/ImVexed/muon/blob/master/muon.go#L215 and https://github.com/ImVexed/muon/blob/master/muon.go#L327 where we are blindly casting objects which will likely end in runtime panics given edge cases. |
In many places throughout the code we have to type cast to and from cgo types.
Currently (ex.), we're not handling errors during those conversions and will likely lead to panics during edge cases.
The text was updated successfully, but these errors were encountered: