Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Review #2

Open
ThomasLee94 opened this issue Aug 12, 2019 · 0 comments
Open

Code Review #2

ThomasLee94 opened this issue Aug 12, 2019 · 0 comments

Comments

@ThomasLee94
Copy link
Collaborator

Readability and Formatting

5/6
Consistent formatting and good use of variable names with good use of comments. To improve this score, do more of the same thing!

Organization and Modularity

5/6
Good separation of concerns, all separated files are necessary.

Standard Library/Conventions:

5/6
Really good use of the Selenium webdriver to circumvent data collection with standard API calls!

Effectiveness of Solution:

5/6
Great solution with an easy to navigate CLI.

Testing and Error Handling:

0/6
No testing but who cares, it is not required and spending the time to write them would be of no benefit.

Algorithmic Complexity

6/6
As good as it needs to be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant