Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this dead? #33

Open
Prid13 opened this issue Jan 26, 2024 · 1 comment
Open

Is this dead? #33

Prid13 opened this issue Jan 26, 2024 · 1 comment

Comments

@Prid13
Copy link

Prid13 commented Jan 26, 2024

Hey,

This was almost too good to be true. I've been searching endlessly for something like this and when I did find this, the actual PR opening URL request isn't working :/

I absolutely love the idea and wanted something like this for the exact same purpose -- to let anyone make edit suggestions to statically hosted Github Pages.

I see, however, that the whole idea is dependent on a third-party server that obfuscates the API token, which is understandable, but that defeats the purpose of this working solely on Github, and that's very well demonstrated today by how the whole editor is blocked from functioning by the API call to the external server being rejected due to CORS policy :(

Any plans to fix that CORS issue? :)

@Prid13
Copy link
Author

Prid13 commented Jan 26, 2024

Nevermind, it actually did work despite the CORS error :O I was just looking in the Issues tab instead of the PR tab, but the PRB0t really did generate PRs with the proposed edits. This is amazing 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant