Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.deb: let user install icinga-archive-keyring package #796

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Sep 3, 2024

@Al2Klimov Al2Klimov added this to the 1.3.0 milestone Sep 3, 2024
@cla-bot cla-bot bot added the cla/signed label Sep 3, 2024
@Al2Klimov Al2Klimov requested a review from oxzi September 6, 2024 08:36
Copy link
Member

@oxzi oxzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

user@host $ docker run --pull=always -t -it --rm debian:bookworm bash
bookworm: Pulling from library/debian
8cd46d290033: Pull complete
Digest: sha256:b8084b1a576c5504a031936e1132574f4ce1d6cc7130bbcc25a28f074539ae6b
Status: Downloaded newer image for debian:bookworm

root@5b3bae13b719:/# apt update
[ snip ]
root@5b3bae13b719:/# apt -y install apt-transport-https wget
[ snip ]
root@5b3bae13b719:/# wget -O icinga-archive-keyring.deb "https://packages.icinga.com/icinga-archive-keyring_latest+debian$(
 . /etc/os-release; echo "$VERSION_ID"
).deb"
[ snip ]
root@5b3bae13b719:/# apt install ./icinga-archive-keyring.deb
[ snip ]
root@5b3bae13b719:/# DIST=$(awk -F"[)(]+" '/VERSION=/ {print $2}' /etc/os-release); \
 echo "deb https://packages.icinga.com/debian icinga-${DIST} main" > \
 /etc/apt/sources.list.d/${DIST}-icinga.list
 echo "deb-src https://packages.icinga.com/debian icinga-${DIST} main" >> \
 /etc/apt/sources.list.d/${DIST}-icinga.list

root@5b3bae13b719:/# apt update
Hit:1 http://deb.debian.org/debian bookworm InRelease
Hit:2 http://deb.debian.org/debian bookworm-updates InRelease
Hit:3 http://deb.debian.org/debian-security bookworm-security InRelease
Get:4 https://packages.icinga.com/debian icinga-bookworm InRelease [11.7 kB]
Err:4 https://packages.icinga.com/debian icinga-bookworm InRelease
  The following signatures couldn't be verified because the public key is not available: NO_PUBKEY C6E319C334410682
Reading package lists... Done
W: GPG error: https://packages.icinga.com/debian icinga-bookworm InRelease: The following signatures couldn't be verified because the public key is not available: NO_PUBKEY C6E319C334410682
E: The repository 'https://packages.icinga.com/debian icinga-bookworm InRelease' is not signed.
N: Updating from such a repository can't be done securely, and is therefore disabled by default.
N: See apt-secure(8) manpage for repository creation and user configuration details.
$ gpg --search-key C6E319C334410682
gpg: data source: https://keys.openpgp.org:443
(1)       1024 bit DSA key C6E319C334410682, created: 2013-11-16

Thus, I am unsure if this should be merged before the key rollover happened.

@julianbrost
Copy link
Contributor

Huh? The keyring package contain both keys at the moment. I'm pretty sure that I've tested that the keyring package worked with the currently published repos before we published the keyring package.

doc/02-Installation.md Show resolved Hide resolved
@julianbrost julianbrost dismissed their stale review September 26, 2024 09:40

My requested change was actually just the comment with the cause for #796 (review) which was addressed. I din't copy & paste the instructions for testing, so I'll dismiss the outdated review instead of approving. But it should be fine since there are two other approvals already.

@Al2Klimov Al2Klimov merged commit e8ed78e into main Sep 26, 2024
32 checks passed
@Al2Klimov Al2Klimov deleted the Al2Klimov-patch-4 branch September 26, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants