Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner radius issue with 1.3.2 #145

Open
otymartin opened this issue May 13, 2018 · 2 comments
Open

Corner radius issue with 1.3.2 #145

otymartin opened this issue May 13, 2018 · 2 comments
Labels

Comments

@otymartin
Copy link

otymartin commented May 13, 2018

@danlozano
Is there something that would cause cornerRadius to not show in UIPageViewController environment?

I have a PageViewController with multiple child controllers. On initial load, there is no cornerRadius, but as soon as I scroll to the next page, corner radius appears. Its almost like a glitch.

This doesnt happen at all in 1.3.0

I tried to reproduce it in this repo but failed.

@omarojo
Copy link

omarojo commented Jun 1, 2018

I have similar issue with a normal UIViewController loaded this way:
let previewVC = G8ARMediaPreviewVC.init(nibName: "G8ARMediaPreviewVC", bundle: FRAMEWORK_BUNDLE) customPresentViewController(presenter, viewController: previewVC, animated: true, completion: nil)

It never shows the rounded corners.

@danlozano
Copy link
Contributor

Yes, sorry.

I introduced this issue in the latest version.

I removed setting .clipsToBounds = true from the presented view controller's view, so that you can round corners and set shadows using Presentr without issue.

But the problem is that if you're view has inner subviews that need to be clipped (like in a page view controller, navigation controller, etc...) you NEED to clip bounds otherwise the subview will pass through and the rounded corners will not be shown.

SO, I am looking into a fix right now so all cases are handled. It will probably be an option to toggle clips to bounds, depending on each presentation's case.

Will update soon! thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants