Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are zeroes in b allowed? #2

Open
chatziko opened this issue Mar 8, 2019 · 2 comments
Open

Are zeroes in b allowed? #2

chatziko opened this issue Mar 8, 2019 · 2 comments

Comments

@chatziko
Copy link

chatziko commented Mar 8, 2019

Hi and thanks for this nice module.

Is there a reason why

@assert all(b .> zero(T))

is not .>= zero(T) ?

@IainNZ
Copy link
Owner

IainNZ commented Mar 10, 2019

Honestly, I can't remember. I do some things here that you normally wouldn't, like checks with exact zero (which would be bad idea with floating point numbers), it might be something like that. Does it work if you remove it??

@chatziko
Copy link
Author

The problem I was facing was actually #3, zeros in b don't seem to be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants