Skip to content

Make better use of BlockedTuple in contract logic to track codomain and domain #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mtfishman opened this issue Feb 5, 2025 · 1 comment
Closed

Make better use of BlockedTuple in contract logic to track codomain and domain #22

mtfishman opened this issue Feb 5, 2025 · 1 comment
Assignees
@ogauthe

Comments

@mtfishman
Copy link
Member

mtfishman commented Feb 5, 2025 •
edited
Loading

This will be helpful when dealing with FusionTensor contraction.
@mtfishman mtfishman mentioned this issue Feb 5, 2025
Open
4 tasks
@mtfishman mtfishman changed the title some parts of contract code path are not compatible with FusionTensors due to loss of domain/codomain distinction, such as in splitdims!. We need to discuss at which parts of the API FusionTensors should reuse and which part would be better with a FusionTensors dedicated implementation. (MATT: I would very strongly prefer generalizing TensorAlgebra where needed rather than making too much specialized functionality in FusionTensors, that was the goal of the package to begin with (even though it isn't quite general enough right now). Let's discuss the issues that you come across and ways to design the code to make it more general.) Make better use of BlockedTuple in contract logic to track codomain and domain Feb 5, 2025
This was referenced Feb 13, 2025
Merged
Closed
@ogauthe ogauthe mentioned this issue Feb 21, 2025
Closed
@ogauthe
Copy link
Collaborator

ogauthe commented Apr 8, 2025

Fixed by #50

@ogauthe ogauthe closed this as completed Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogauthe ogauthe

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mtfishman @ogauthe