Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix: Make osparc.local functional again - various minor fixes #894

Merged
merged 22 commits into from
Dec 5, 2024
Merged

🐛 Fix: Make osparc.local functional again - various minor fixes #894

merged 22 commits into from
Dec 5, 2024

Conversation

mrnicegyu11
Copy link
Member

@mrnicegyu11 mrnicegyu11 commented Nov 27, 2024 •
edited
Loading

What do these changes do?

  • Fix local minio S3 bucket creation - accept faulty SSL certificate
  • Fix local graylog provisioning - accept faulty SSL certificate everywhere
  • Fix local registry docker-compose
  • Add debug ops-traefik accesslog in json format (with lots of info) to osparc.local
  • Add missing scheme (http --> https) scheme redirect to local-deployment
  • Fix pyenv version (please check if this is ok @YuryHrytsuk )
  • Fix pylint by ignoring jupyter-nb-config file which cannot be parser.
  • Fix dask key-file issues (copying files, specifying docker secrets as external)
  • .gitignore enhancements.

Related issue/s

Related PR/s

Should be merged before #893
Goes with https://git.speag.com/oSparc/osparc-ops-deployment-configuration/-/merge_requests/1125

Checklist

  • I tested and it works

@mrnicegyu11 mrnicegyu11 added the t:bug Something isn't working label Nov 27, 2024
@mrnicegyu11 mrnicegyu11 added this to the Event Horizon milestone Nov 27, 2024
@mrnicegyu11 mrnicegyu11 self-assigned this Nov 27, 2024
@mrnicegyu11 mrnicegyu11 mentioned this pull request Nov 27, 2024
Merged
1 task
@mrnicegyu11 mrnicegyu11 marked this pull request as ready for review December 2, 2024 09:58
YuryHrytsuk
YuryHrytsuk approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@YuryHrytsuk YuryHrytsuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Left a few comments

.python-version Outdated Show resolved Hide resolved
scripts/create-s3-bucket.bash Show resolved Hide resolved
scripts/deployments/deploy_everything_locally.bash Show resolved Hide resolved
services/traefik/docker-compose.local.yml Show resolved Hide resolved
.pylintrc Show resolved Hide resolved
@mrnicegyu11 mrnicegyu11 merged commit c37a5a6 into ITISFoundation:main Dec 5, 2024
3 checks passed
@mrnicegyu11 mrnicegyu11 mentioned this pull request Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuryHrytsuk YuryHrytsuk YuryHrytsuk approved these changes

Assignees

@mrnicegyu11 mrnicegyu11

Labels
t:bug Something isn't working
Projects
None yet
Milestone
Event Horizon
Development

Successfully merging this pull request may close these issues.
2 participants
@mrnicegyu11 @YuryHrytsuk