From d608ac070c782f3e046ae05fe546ea9f436b0530 Mon Sep 17 00:00:00 2001 From: Ric-De Date: Wed, 15 May 2024 03:38:58 +0200 Subject: [PATCH] Refactor AdditionalTrainingList-Erase commented code in 2 files --- .../api/AdditionalTrainingListController.php | 31 ------------------- app/Service/AdditionalTrainingService.php | 29 ----------------- 2 files changed, 60 deletions(-) diff --git a/app/Http/Controllers/api/AdditionalTrainingListController.php b/app/Http/Controllers/api/AdditionalTrainingListController.php index 909117ec..885a54e4 100644 --- a/app/Http/Controllers/api/AdditionalTrainingListController.php +++ b/app/Http/Controllers/api/AdditionalTrainingListController.php @@ -1,36 +1,5 @@ additionalTrainingService = $additionalTrainingService; - } - - public function __invoke($uuid) - { - try { - $additionalTrainingDetail = [ - 'additional_trainings' => $this->additionalTrainingService->getAdditionalTrainingDetails($uuid), - ]; - return response()->json($additionalTrainingDetail); - } catch (ModelNotFoundException $e) { - return response()->json(['error' => 'Student not found.'], 404); - } catch (Exception $e) { - return response()->json(['error' => 'Internal server error.'], 500); - } - } -} */ - declare(strict_types=1); namespace App\Http\Controllers\api; diff --git a/app/Service/AdditionalTrainingService.php b/app/Service/AdditionalTrainingService.php index 7c509dbe..b4d226f4 100644 --- a/app/Service/AdditionalTrainingService.php +++ b/app/Service/AdditionalTrainingService.php @@ -1,34 +1,5 @@ with('resume')->firstOrFail(); - $resume = $student->resume; - $additionalTrainingIds = json_decode($resume->additional_trainings_ids); - $additionalTrainings = AdditionalTraining::findMany($additionalTrainingIds); - - return $additionalTrainings->map(function ($additionalTraining) { - return [ - 'uuid' => $additionalTraining->id, - 'course_name' => $additionalTraining->course_name, - 'study_center' => $additionalTraining->study_center, - 'course_beginning_year' => $additionalTraining->course_beginning_year, - 'course_ending_year' => $additionalTraining->course_ending_year, - 'duration_hrs' => $additionalTraining->duration_hrs, - ]; - }); - } -} */ - declare(strict_types=1); namespace App\Service;