From 5ecefab31cfb4b1a1de18d0a9c26c0124efa6382 Mon Sep 17 00:00:00 2001
From: DudiDude <acerwork001@proton.me>
Date: Thu, 16 May 2024 11:39:26 +0200
Subject: [PATCH] SomeMissingErrorsInTestImproveService

---
 app/Service/User/UserRegisterService.php      |  3 +-
 .../Service/User/RegisterUserServiceTest.php  | 41 ++++++++++++++-----
 2 files changed, 31 insertions(+), 13 deletions(-)

diff --git a/app/Service/User/UserRegisterService.php b/app/Service/User/UserRegisterService.php
index f772d253..e64b5a43 100644
--- a/app/Service/User/UserRegisterService.php
+++ b/app/Service/User/UserRegisterService.php
@@ -38,7 +38,6 @@ public function createUser(RegisterRequest $registerData): array | bool
 			
 			$success['token'] = $user->createToken('ITAcademy')->accessToken;
 			
-			
 			DB::commit();
 		} catch (\PDOException $e) {
 			// Woopsy
@@ -50,7 +49,7 @@ public function createUser(RegisterRequest $registerData): array | bool
 		if(empty($user->email)){
 			return False;
 		}*/
-		
+		//$success['token'] = $user->createToken('ITAcademy')->accessToken;
         $success['email'] = $user->email;
 		
 		return $success;
diff --git a/tests/Feature/Service/User/RegisterUserServiceTest.php b/tests/Feature/Service/User/RegisterUserServiceTest.php
index 110732ab..bc6356ff 100644
--- a/tests/Feature/Service/User/RegisterUserServiceTest.php
+++ b/tests/Feature/Service/User/RegisterUserServiceTest.php
@@ -200,10 +200,10 @@ public function test_required_fields_for_user_creation()
     /**
      * @dataProvider required_fields_for_user_creation_provider 
      */
-    public function test_required_fields_for_user_creation_my(array $array)
+    public function test_required_fields_for_user_creation_my(array $array, bool $resultCorrect)
     {
         // Missing 'username' field
-        $registerData1 = new RegisterRequest([
+        $registerData = new RegisterRequest([
             //'username' => 'test_username',
             'username' => $array['username'] ?? "",
             'specialization' => $array['specialization'] ?? "",
@@ -214,15 +214,25 @@ public function test_required_fields_for_user_creation_my(array $array)
         ]);
 
         //$this->expectException(Exception::class);
-        $this->userService->createUser($registerData1);
-        $succes  = $this->userService->createUser($registerData1);
-        $this->assertEquals(False, $succes);
+        //$this->userService->createUser($registerData1);
+        $success  = $this->userService->createUser($registerData);
+        //$this->assertEquals(False, $succes);
+        //$this->assertEquals($this->validationMessage, $succes);
+        
+        if($resultCorrect){
+			//$this->assertEquals($this->validationMessage, $succes);
+			$this->assertEquals(True, empty($success['email']) == False && empty($success['token']) == False );
+			
+		}else{
+			$this->assertEquals($resultCorrect, $success);
+		}
+        
 	}
     
     static function required_fields_for_user_creation_provider()
     {
 		$array = array(
-			// Missing 'username' field
+			// Missing 'username' field - 0 
 			array(
 				array(
 					//'username' => 'hoho',
@@ -232,8 +242,9 @@ static function required_fields_for_user_creation_provider()
 					'password' => 'password123',
 					'dni' => '27827083G'
 				),
+				True
 			),
-			// Missing 'email' field
+			// Missing 'email' field - 1
 			array(
 				array(		
 					'username' => 'test_username',
@@ -242,8 +253,10 @@ static function required_fields_for_user_creation_provider()
 					'password' => 'password123',
 					'dni' => '27827083G'
 				),
+				//Returning False because email is not specified
+				False
 			),
-			// Missing 'dni' field
+			// Missing 'password' field  - 2
 			array(
 				array(		
 					'username' => 'test_username',
@@ -252,8 +265,10 @@ static function required_fields_for_user_creation_provider()
 					'email' => 'janesmith@example.com',
 					'dni' => '27827083G'
 				),
+				True
 			),
-			// Missing 'specialization' field
+			
+			//// Missing 'dni' field  - 3
 			array(
 				array(		
 					'username' => 'test_username',
@@ -262,8 +277,9 @@ static function required_fields_for_user_creation_provider()
 					'terms' => 'true',
 					'password' => 'password123'
 				),
+				True
 			),
-			// Missing 'terms' field
+			// Missing 'specialization' field - 4
 			array(
 				array(		
 					'username' => 'Alice Brown',
@@ -272,9 +288,11 @@ static function required_fields_for_user_creation_provider()
 					'terms' => 'true',
 					'password' => 'password123'
 				),
+				//False because "specialization" not in DB ENUM
+				False
 			),
 			
-			// Missing 'terms' field
+			// Missing 'terms' field - 5
 			array(
 				array(		
 					'username' => 'Alice Brown',
@@ -283,6 +301,7 @@ static function required_fields_for_user_creation_provider()
 					'specialization' => 'Backend',
 					'password' => 'password123'
 				),
+				True
 			),