Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request/Idea: better handling of duplicate files when adding files to upload #467

Open
ErykKul opened this issue Aug 23, 2024 · 0 comments · May be fixed by #478
Open

Feature Request/Idea: better handling of duplicate files when adding files to upload #467

ErykKul opened this issue Aug 23, 2024 · 0 comments · May be fixed by #478
Labels
FY25 Sprint 4 FY25 Sprint 4 FY25 Sprint 5 FY25 sprint 5 Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: File Upload Page SPA.Q3 Not related to any specific Q3 feature SPA

Comments

@ErykKul
Copy link
Contributor

ErykKul commented Aug 23, 2024

Overview of the Feature Request
Current behavior:

  • adding file with the same name (and label) as a file that is already being added results in the new file being silently ignored
  • files with different names but with the same checksum are being added without a warning

Possible improvements

  • error is given (e.g., popup) when a file with the same name is already being added
  • warning is given when a file with the same checksum is already being added

It might be also useful to extend the checks for identical files to the files already present in the dataset. It is currently not done. For example, when a file with a name and label already exists in the dataset, the new file gets a suffix "-1" (e.g., "test-1.json" when "test.json" is already in the dataset). A warning could be given before adding such file. Also, a warning should be given if a file with the same checksum is already present in the dataset. However, this might slow down uploads for large datasets containing thousands of files, and when uploading only few new files. Therefore, this remains out of scope for this issue.

What kind of user is the feature intended for?
(Example users roles: API User, Curator, Depositor, Guest, Superuser, Sysadmin)
Depositor

What inspired the request?
File upload feature as it is implemented now.

What existing behavior do you want changed?
Better edge case handling when uploading files.

Any brand-new behavior do you want to add to Dataverse?
File upload is a new feature that is currently being developed.

Any open or closed issues related to this feature request?
#431

@ErykKul ErykKul self-assigned this Aug 23, 2024
@ErykKul ErykKul moved this to In Progress 💻 in IQSS Dataverse Project Aug 23, 2024
@ErykKul ErykKul added Size: 10 A percentage of a sprint. 7 hours. SPA: File Upload Page labels Aug 23, 2024
@cmbz cmbz added FY25 Sprint 5 FY25 sprint 5 FY25 Sprint 4 FY25 Sprint 4 labels Aug 28, 2024
@g-saracca g-saracca added the SPA label Sep 9, 2024
@GPortas GPortas added SPA.Q3 Not related to any specific Q3 feature Original size: 10 labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FY25 Sprint 4 FY25 Sprint 4 FY25 Sprint 5 FY25 sprint 5 Original size: 10 Size: 10 A percentage of a sprint. 7 hours. SPA: File Upload Page SPA.Q3 Not related to any specific Q3 feature SPA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants