From f1b54be8009e7ae42f2054bed208a50c1a4b3c1c Mon Sep 17 00:00:00 2001 From: Sebastian Ullrich Date: Wed, 11 Oct 2023 15:31:21 +0200 Subject: [PATCH] format and signify mathlib instructions count by absolute value --- backend/backend/pom.xml | 2 ++ .../backend/data/significance/SignificanceDetector.java | 4 ++++ backend/runner/pom.xml | 2 ++ frontend/src/components/comparison/RunComparisonTable.vue | 2 +- frontend/src/components/rundetail/MeasurementsDisplay.vue | 2 +- frontend/src/components/runs/RunSignificanceChips.vue | 4 ++-- 6 files changed, 12 insertions(+), 4 deletions(-) diff --git a/backend/backend/pom.xml b/backend/backend/pom.xml index 87950bd33..bbfe5c870 100644 --- a/backend/backend/pom.xml +++ b/backend/backend/pom.xml @@ -172,6 +172,8 @@ ${project.basedir}/../../.git + false + false true ${project.build.outputDirectory}/git.properties diff --git a/backend/backend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java b/backend/backend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java index 6f51ce802..ba5318d3e 100644 --- a/backend/backend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java +++ b/backend/backend/src/main/java/de/aaaaaaah/velcom/backend/data/significance/SignificanceDetector.java @@ -68,6 +68,10 @@ public Optional getSignificance(Run run, Collection co } private boolean isSignificantDifference(DimensionDifference diff) { + if (diff.getDimension().getBenchmark().startsWith("~")) + // 1B instructions + return diff.getDiff() >= 1_000_000_000; + boolean relSignificant = diff.getReldiff() .map(reldiff -> Math.abs(reldiff) >= significanceFactors.getRelativeThreshold()) // There is no reldiff if the first value is 0. But if the second value is also zero, that diff --git a/backend/runner/pom.xml b/backend/runner/pom.xml index 53f8cd17d..464fb9b62 100644 --- a/backend/runner/pom.xml +++ b/backend/runner/pom.xml @@ -66,6 +66,8 @@ ${project.basedir}/../../.git + false + false true ${project.build.outputDirectory}/git.properties diff --git a/frontend/src/components/comparison/RunComparisonTable.vue b/frontend/src/components/comparison/RunComparisonTable.vue index 465cefdb4..e2cbccaf7 100644 --- a/frontend/src/components/comparison/RunComparisonTable.vue +++ b/frontend/src/components/comparison/RunComparisonTable.vue @@ -65,7 +65,7 @@ import { Prop } from 'vue-property-decorator' const numberFormat: Intl.NumberFormat = new Intl.NumberFormat( new Intl.NumberFormat().resolvedOptions().locale, - { maximumFractionDigits: 3 } + { maximumFractionDigits: 3, notation: 'compact' } ) class TableItem { diff --git a/frontend/src/components/rundetail/MeasurementsDisplay.vue b/frontend/src/components/rundetail/MeasurementsDisplay.vue index 27737de4d..13984f967 100644 --- a/frontend/src/components/rundetail/MeasurementsDisplay.vue +++ b/frontend/src/components/rundetail/MeasurementsDisplay.vue @@ -85,7 +85,7 @@ import { vxm } from '@/store' const numberFormat: Intl.NumberFormat = new Intl.NumberFormat( new Intl.NumberFormat().resolvedOptions().locale, - { maximumFractionDigits: 3 } + { maximumFractionDigits: 3, notation: 'compact' } ) class Item { diff --git a/frontend/src/components/runs/RunSignificanceChips.vue b/frontend/src/components/runs/RunSignificanceChips.vue index ede63c536..bec34fde3 100644 --- a/frontend/src/components/runs/RunSignificanceChips.vue +++ b/frontend/src/components/runs/RunSignificanceChips.vue @@ -68,7 +68,7 @@ import { Prop } from 'vue-property-decorator' const numberFormat: Intl.NumberFormat = new Intl.NumberFormat( new Intl.NumberFormat().resolvedOptions().locale, - { maximumFractionDigits: 1 } + { maximumFractionDigits: 1, notation: 'compact' } ) const iconMappings = { @@ -102,7 +102,7 @@ class RelevantChange { this.change = change } else { - this.change = difference.relDiff + this.change = difference.relDiff && !this.id.benchmark.startsWith('~') ? this.formatPercentage(difference.relDiff) : this.formatNumber(difference.absDiff) }