Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple control flow issues in ParameterInputDialog of Swan Implementation #47

Open
1 task
shashwatsridhar opened this issue Dec 18, 2021 · 0 comments
Open
1 task

Comments

@shashwatsridhar
Copy link
Collaborator

In the current implementation, the ParameterInputDialog for the Swan Implementation has three buttons - Cancel, Update Plot and Calculate. For one run of the algorithm, the Update Plot button must be clicked first in order to instantiate different Kmeans Solvers, and only then should the Calculate button be clicked. This is not clear from the design of the GUI itself, it's worth:

  • greying out the Calculate button until the Update Plot is clicked (and the Solvers are successfully calculated)

Additionally, this line should be fixed so that the chosen_solver is not looked for unless _solvers is an empty list. It should essentially read:

if not self._solvers:

This should also fix the error which is raised when Cancel is pressed in the ParameterInputDialog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant