Properly implement Resource#get. This closes Granicus#33

Author: Billy Reisinger

README.md

@@ -25,24 +25,37 @@ An instance of the `Infoblox::Connection` class is necessary:
     connection = Infoblox::Connection.new(username: '', password: '', host: '')
 
 ## Reading
-Each resource class implements `all` and `find`.  You can use the `_max_results` and `_return_fields` parameters for both of these methods. See the Infoblox WAPI documentation on how to use these parameters. 
+Each resource class implements `.all`, `.find`, and `#get`.   
 
+### `.find`
+Use find when you don't know what you are looking for or you don't have a `_ref` saved (see `get` below).  Use `_max_results` to limit / expand the number of returned results.
+
+    # You can find hosts that match a regular expression:
+    Infoblox::Host.find(connection, {"name~" => "demo[0-9]{1,}-web.domain"})
+    # => [...]
+
+### `.all`
+Show all results (note that this is limited by `_max_results`).  Use this cautiously when you have a large potential set of results.
+    
     # Find all networks. Note that this is limited to 1000 objects, as per the 
     # Infoblox WAPI documentation. 
     Infoblox::Network.all(connection)
     # => [...]
-    
+
     # If you want more than 1,000 records, use `_max_results`:
     Infoblox::Network.all(connection, _max_results: 7890)
 
-    # You can find hosts that match a regular expression:
-    Infoblox::Host.find(connection, {"name~" => "demo[0-9]{1,}-web.domain"})
-    # => [...]
-
 The usage of search parameters is well-documented in the Infoblox WAPI documentation, and this client supports them fully.
 
+### `#get`
+Use this when you have saved a reference (`_ref`) and want to load it later. 
+
+    host = Infoblox::Host.new(:connection => c, :_ref => ref).get
+    puts host.name 
+    # => foo.bar
+
 ## Searching
-You can also search across the Infoblox cluster using the `Infoblox::Search` resource. The response will contain any number of `Infoblox::Resource` subclass instances. 
+You can also search across all Infoblox resource types using the `Infoblox::Search` resource. The response will contain any number of `Infoblox::Resource` subclass instances. 
 
     result = Infoblox::Search.find(connection, "search_string~" => "webserver-")
     # => [#<Infoblox::Host>, #<Infoblox::Ptr>, ...]
@@ -183,6 +196,7 @@ To run the tests:
 
 To run the integration tests (you will be prompted for your Infoblox credentials):
 
+    INTEGRATION=true bundle
     INTEGRATION=true rspec
 
 Please note that the integration tests do not work in Ruby 1.8.7, but the unit tests function normally.

lib/infoblox/resource.rb

@@ -125,17 +125,7 @@ def self.resource_map
     end
 
     def initialize(attrs={})
-      attrs.each do |k,v|
-        # Some things have specialized writers, 
-        # like Host
-        if respond_to?("#{k}=")
-          send("#{k}=", v)
-        
-        # Some things don't have writers (i.e. remote_attr_reader fields)
-        else
-          instance_variable_set("@#{k}", v)
-        end
-      end
+      load_attributes(attrs)
     end
 
     def post
@@ -148,8 +138,10 @@ def delete
       connection.delete(resource_uri).status == 200
     end
 
-    def get(params={})
-      connection.get(resource_uri, params)
+    def get(params=self.class.default_params)
+      response = connection.get(resource_uri, params).body
+      load_attributes(JSON.parse(response))
+      self
     end
 
     def put
@@ -179,6 +171,20 @@ def remote_attribute_hash(write=false, post=false)
     def unquote(str)
       str.gsub(/\A['"]+|['"]+\Z/, "")
     end
+
+    def load_attributes(attrs)
+      attrs.each do |k,v|
+        # Some things have specialized writers, 
+        # like Host
+        if respond_to?("#{k}=")
+          send("#{k}=", v)
+        
+        # Some things don't have writers (i.e. remote_attr_reader fields)
+        else
+          instance_variable_set("@#{k}", v)
+        end
+      end
+    end
   end
 
 end

lib/infoblox/version.rb

@@ -1,3 +1,3 @@
 module Infoblox
-  VERSION = "0.4.1"
+  VERSION = "0.5.0"
 end

spec/resource_spec.rb

@@ -90,6 +90,19 @@ class FooResource < Infoblox::Resource
     expect(f.sect).to eq(:larry)
   end
 
+  it 'should load attributes on get' do
+    conn     = double
+    uri      = Infoblox.base_path + "a:ref:that:is:fake"
+    json     = {:name => "john", :junction => "hi", :extattrs => {"foo" => 3}}.to_json
+    response = FooResponse.new(json)
+    expect(conn).to receive(:get).with(uri, FooResource.default_params).and_return(response)
+    f        = FooResource.new(:connection => conn, :_ref => "a:ref:that:is:fake")
+    f.get
+    expect(f.name).to eq("john")
+    expect(f.junction).to eq("hi")
+    expect(f.extattrs).to eq({"foo" => 3})
+  end
+
   it 'should map wapi objects to classes' do
     @expected = {}
     ObjectSpace.each_object(Class) do |p|