Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD] Notification subscriptions refactor #2311

Open
szabozoltan69 opened this issue Nov 19, 2024 · 8 comments
Open

[PROD] Notification subscriptions refactor #2311

szabozoltan69 opened this issue Nov 19, 2024 · 8 comments
Assignees

Comments

@szabozoltan69
Copy link
Contributor

Issue

Instead of the recent
country ∪ region ∪ disaster type ∪ (emergencies/operations/surge alerts)

we should use the subscriptions this way:

(country ∪ region) ∩ disaster type ∩ (emergencies/operations/surge alerts)

So we should only send the country+region/disaster_type filtered notifications (of the subscribed entities).

@szabozoltan69 szabozoltan69 self-assigned this Nov 19, 2024
@szabozoltan69
Copy link
Contributor Author

@tovari @mariam-yu – if this logic should be expressed by some new texts, please say it.

@mariam-yu
Copy link

@szabozoltan69 what does the icon mean?

@szabozoltan69
Copy link
Contributor Author

@mariam-yu you mean ∪ and ∩? Union and Intersection.

@szabozoltan69
Copy link
Contributor Author

szabozoltan69 commented Nov 20, 2024

Union means: any of the given entities is used independently. It is an "OR".
Intersection means: the given entities are used together. It is an "AND".
The geographical (country, region) and disaster-type parameters are "narrowing" the subscriptions.

So, some examples for this new
(country ∪ region) ∩ disaster type ∩ (emergencies/operations/surge alerts)
system:
Given:
(Italy ∪ Europe) ∩ floods ∩ (new emergencies / new operations / new surge alerts) – will receive notifications, when a new flood related emg/opr/sur appears in Europe (or Italy, but it is redundant info now, because "via Europe" all Italian events are covered).
So, no notification will arrive for italian wood fires.

(Italy ∪ Europe) ∩ - ∩ (new emergencies / new operations / new surge alerts) – will receive emg/opr/sur notifications, when any disaster appears in Europe.

(Zambia) ∩ floods ∩ (new surge alerts) – will receive notifications, when a new flood related surge alert appears in Zambia. (No flood related (or other) emergencies, no flood related (or other) operations are generating notifications in this case.)

(Zambia ∪ Europe) ∩ floods ∩ (new surge alerts) – will receive notifications, when a new flood related surge alert appears in Europe or Zambia. (No flood related (or other) emergencies, no flood related (or other) operations are generating notifications, if they are outside of Europe and outside of Zambia.)

emergencies/operations – will receive notifications about emg/opr, but not for surge alerts: anywhere, any disaster type.

emergencies/operations/surge alerts – will receive notifications about emg/opr/sur: anywhere, any disaster type.

(There is personneldeployment message subscription option also, but not used in these examples. The digests are global, not narrowed down by geo or disaster-type.)

@mariam-yu
Copy link

@szabozoltan69 Thanks so much for the detailed clarifications and glad we are addressing this, as there were a number of such issues that came up during the studies. I suppose this will be then the new logic

Selecting region > country _[if selecting country, does it mean they only get that country and not region, i.e. country negates region?]_ as a first step
New emergencies/weekly digest (for that region/country)
Selecting disaster types (will be for that region/country)
Selecting surge (for that region/country)

Correct?

For PER, honestly I think we should remove from here - it's confusing people and applies only to a small number of people. Potentially also to remove New Operations as don't think people get the different between this and new emergencies. General announcements we could make into Platform updates? @tovari what do you think?

@szabozoltan69
Copy link
Contributor Author

szabozoltan69 commented Nov 20, 2024

About the first step, we can let the user know that they can leave it blank, if want to receive notifications globally. (The same for disaster types.)

Operations could remain (by my wish), it's fine to be notified about new appeals.

@mariam-yu
Copy link

@szabozoltan69 @tovari per my offline chat with Zoly this is what we came to an agreement, but @tovari let us know what you think.

a) Weekly digest is global and agnostic of after selection.
b) Then comes region/country selection. If country selected, the user is notified that they won't get updates for region. It's an EITHER/OR selection.
c) New emergencies, Disaster type, Surge come after and depend on the region/country selection.
d) TBD on PER due dates here, New Operations. These are not clear to the users, but needs a further discussion with the team on where/how to place them.
e) Suggestion to rename General announcements to Platform updates, unless they mean different things. Also, is this in place already?
f) !!! Suggestion to auto-subscribe new users to notifications (let's discuss!), as most won't know about it.

Design will be updated to reflect the above. @szabozoltan69 please confirm whether I missed or misunderstood anything.

@szabozoltan69
Copy link
Contributor Author

I think at region/country selection we should clearly sign that it is not mandatory to choose any.
The Disaster type has the same role, "narrowing" the notifications scope (also not mandatory).

Thanks for the ideas, dear @mariam-yu !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants