Merge pull request #1545 from IFRCGo/fix/make-nicer-notifications-on-…

…dref Create nicer notifications on DREF
IFRCGo · Oct 3, 2022 · 2d35f82 · 2d35f82
2 parents a55abd9 + ac963f2
commit 2d35f82
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/dref/serializers.py b/dref/serializers.py
@@ -426,7 +426,7 @@ def create(self, validated_data):
             return dref_assessment_report
         dref = super().create(validated_data)
         transaction.on_commit(
-            lambda: send_dref_email.delay(dref.id)
+            lambda: send_dref_email.delay(dref.id, 'New')
         )
         return dref
 
@@ -460,7 +460,7 @@ def update(self, instance, validated_data):
             return dref_assessment_report
         dref = super().update(instance, validated_data)
         transaction.on_commit(
-            lambda: send_dref_email.delay(dref.id)
+            lambda: send_dref_email.delay(dref.id, 'Updated')
         )
         return dref
 

diff --git a/dref/tasks.py b/dref/tasks.py
@@ -6,15 +6,15 @@
 
 
 @shared_task
-def send_dref_email(dref_id):
+def send_dref_email(dref_id, new_or_updated=''):
     instance = Dref.objects.get(id=dref_id)
     email_context = get_email_context(instance)
     users_emails = [t.email for t in instance.users.iterator()]
     if users_emails:
         send_notification(
-            f'New DREF: {instance.title}',
+            f'{new_or_updated} DREF: {instance.title}',
             users_emails,
             render_to_string('email/dref/dref.html', email_context),
-            'New DREF'
+            f'{new_or_updated} DREF'
         )
     return email_context