Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCHEMA] - rename lidar_config to remote_sensing_config #259

Open
stephenholleran opened this issue May 23, 2024 · 3 comments
Open

[SCHEMA] - rename lidar_config to remote_sensing_config #259

stephenholleran opened this issue May 23, 2024 · 3 comments
Assignees
Labels
breaking change Highlights that this issue will be a breaking change enhancement New feature or request

Comments

@stephenholleran
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
While working on issue #254 in the PR #257 we realised that these additional properties (logger_stated_device_datum_plane_height_m and logger_stated_device_orientation_deg) could be applied to sodars too. Therefore the table these have gone under, lidar_config is not appropriate anymore.

Describe the solution you'd like
We should rename lidar_config to remote_sensing_config or rsd_config or remote_sensing_device_config or ??????

Describe alternatives you've considered
We can leave it as is but on our bi-weekly call, #129 (comment), we thought this wouldn't be a good idea and alienates sodars.

Additional context
This would be a breaking change.

@stephenholleran stephenholleran added enhancement New feature or request breaking change Highlights that this issue will be a breaking change labels May 23, 2024
@stephenholleran stephenholleran self-assigned this May 23, 2024
@kersting
Copy link
Collaborator

@stephenholleran I vote for remote_sensing_config. I'm happy to either review a possible change or take this one if we agree to proceed with it. As discussed in the call, probably we should pack all the breaking changes in one DEV branch.

@kersting
Copy link
Collaborator

@stephenholleran I'm open to start working in all the breaking changes that we have been discussing. We can discuss when to start in our next bi-weekly meeting.

@stephenholleran
Copy link
Collaborator Author

@kersting I have created a branch called dev-breaking-changes where we can work on the breaking changes without it impacting the development of the none breaking changes work which get merged into the dev branch.

https://github.com/IEA-Task-43/digital_wra_data_standard/tree/dev-breaking-changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Highlights that this issue will be a breaking change enhancement New feature or request
Projects
Status: To do
Development

No branches or pull requests

2 participants