-
Notifications
You must be signed in to change notification settings - Fork 383
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is_different behavior differs with numpy vs without numpy #930
Comments
@thequilo I just noticed that #928 did introduce some unintended changes. With numpy haven released fixes to restore the old array_equal functionality, could we revert these changes? This one breaks now: from sacred import Experiment
ex = Experiment()
@ex.config
def config():
a = dict(b=[])
@ex.automain
def main(a):
return a
|
Yeah, I forgot the |
@n-gao sorry for the late response, I'm currently out of the office. Does the current master work? If so, I can do a quick bugfix release. |
@thequilo Sorry for the late reply. The master branch fixes my issues :) |
Done! |
In #928 the issue came up that the behavior of
is_different
incustom_containers
differs if numpy is installed vs when it is not installed. Here is an example:This looks like undesired behavior, but I have to investigate further what impact this issue has before I fix it.
The text was updated successfully, but these errors were encountered: