Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Integrate hardcoded strings into translation workflows #2797

Open
jfmcquade opened this issue Feb 14, 2025 · 0 comments
Open

[FEATURE] Integrate hardcoded strings into translation workflows #2797

jfmcquade opened this issue Feb 14, 2025 · 0 comments
Labels
feature Work on app features/modules

Comments

@jfmcquade
Copy link
Collaborator

What?
A limited number of hardcoded strings are included as default values in the app config:

feedback_add_button_text: "Add Feedback",
feedback_suggest_change_text: "Suggest Change",
feedback_sent_text: "Thank you for your feedback",
feedback_unsent_text: "You are currently offline. Feedback will be sent when next online",
notification_default_title: "Notification",
notification_default_text: "You have a new message",

These strings should be integrated into the translation workflows somehow.

Another example of hardcoded strings is these navigation labels in the tour service:

nextLabel: this.translateService.translateValue("Next"),
prevLabel: this.translateService.translateValue("Previous"),
doneLabel: this.translateService.translateValue("Done"),

I believe these are currently managed by manually ensuring that the strings are included in any complete set of deployment app strings for translation (@esmeetewinkel is that right?).

We may also want additional hardcoded strings in other contexts in the future, for example, see this discussion on #2788. So likely we want to gather all such strings on one place and find a general solution for including them all intranslations.

@jfmcquade jfmcquade added the feature Work on app features/modules label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules
Projects
None yet
Development

No branches or pull requests

1 participant