Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Contact field and localstorage improvements #2322

Open
10 tasks
chrismclarke opened this issue May 21, 2024 · 0 comments
Open
10 tasks

[FEATURE] Contact field and localstorage improvements #2322

chrismclarke opened this issue May 21, 2024 · 0 comments
Labels
feature Work on app features/modules needs discussion Needs discussion

Comments

@chrismclarke
Copy link
Member

chrismclarke commented May 21, 2024

What?
Following work in #2320, a number of follow-up improvements identified for 1 or more PRs.

Contact Field Implementation

  • Add a lightweight migration system to allow us to handle future localstorage value changes
  • Replace rp-contact-field prefix with app deployment name (migrate existing, decide whether to keep prefix when syncing to server or not)
  • Consider refactoring localStorage service to store json objects that include data type
  • Consider implementing with RXDB to store localstorage values in-memory and persist to disk asynchronously (similar to dynamic-data service)

Code Tidying

  • Consider refactoring rest of appConfig fields to protected (e.g. selected_text_field, app_update_available_field)
  • Consider simplifying templateFieldService to be more of a loose wrapper around localstorage service - if implemented with rxdb could expose value subscription methods
  • Consider removing setJson and getJson methods
  • Remove final references to rp-contact-field from test suites
  • Consider refactoring the app-events.service to not persist a combined value to localstorage and instead just track a few protected field entries
  • Refactor task.service to use protected fields instead of arbitrary setField operations and highlightedTaskField variable
@chrismclarke chrismclarke added the feature Work on app features/modules label May 21, 2024
@chrismclarke chrismclarke added the needs discussion Needs discussion label May 21, 2024
@chrismclarke chrismclarke changed the title [FEATURE] [FEATURE] Contact field and localstorage improvements May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Work on app features/modules needs discussion Needs discussion
Projects
None yet
Development

No branches or pull requests

1 participant