Skip to content

Commit 46413a7

Browse files
committed
chore: code tidying
1 parent 133f3b6 commit 46413a7

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

packages/scripts/src/commands/app-data/convert/processors/flowParser/flowParser.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { arrayToHashmap, groupJsonByKey, IContentsEntry } from "../../utils";
55
import BaseProcessor from "../base";
66

77
export class FlowParserProcessor extends BaseProcessor<FlowTypes.FlowTypeWithData> {
8-
public cacheVersion = 20240220.2;
8+
public cacheVersion = 20240315.0;
99

1010
public parsers: { [flowType in FlowTypes.FlowType]: Parsers.DefaultParser } = {
1111
data_list: new Parsers.DataListParser(this),

packages/scripts/src/commands/app-data/convert/processors/flowParser/parsers/template.parser.ts

+13-5
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,7 @@ export class TemplateParser extends DefaultParser {
2525
// when unique name not specified assume namespacing with template value (flow_name)
2626
// or the row type for non-templates
2727
if (!row.name) {
28-
if (row.type === "template") {
29-
row.name = row.value;
30-
} else {
31-
row.name = `${row.type}_${rowNumber}`;
32-
}
28+
row.name = this.generateRowName(row, rowNumber);
3329
}
3430
// track path to row when nested
3531
row._nested_name = nestedPath ? `${nestedPath}.${row.name}` : row.name;
@@ -152,6 +148,18 @@ export class TemplateParser extends DefaultParser {
152148
});
153149
}
154150

151+
/** Automatically generate a row name when not provided by author */
152+
private generateRowName(row: FlowTypes.TemplateRow, rowNumber: Number) {
153+
switch (row.type) {
154+
// template row name assigned to target template name
155+
case "template":
156+
return row.value;
157+
// default use combination of row type and row number
158+
default:
159+
return `${row.type}_${rowNumber}`;
160+
}
161+
}
162+
155163
private qualityControlCheck(row: FlowTypes.TemplateRow) {
156164
const errors: string[] = [];
157165

src/app/shared/utils/utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { format } from "date-fns";
22
import { diff } from "deep-object-diff";
33
import { Observable } from "rxjs";
44
import { map, pairwise, filter, share } from "rxjs/operators";
5-
import * as Sentry from "@sentry/angular";
5+
import * as Sentry from "@sentry/angular-ivy";
66
import { FlowTypes } from "../model";
77
import { objectToArray } from "../components/template/utils";
88
import marked from "marked";

0 commit comments

Comments
 (0)