chore: exclude PII user data fields from server sync

Author: jfmcquade

packages/data-models/fields.ts

@@ -28,3 +28,9 @@ enum PROTECTED_FIELDS {
 export const getProtectedFieldName = (key: IProtectedFieldName) => `_${PROTECTED_FIELDS[key]}`;
 
 export type IProtectedFieldName = keyof typeof PROTECTED_FIELDS;
+
+/** A list of protected fields that should not be synced to the server */
+export const EXCLUDED_FIELDS: IProtectedFieldName[] = [
+  "AUTH_USER_DISPLAY_NAME",
+  "AUTH_USER_PROFILE_IMAGE_URL",
+];

src/app/shared/services/server/server.service.ts

@@ -1,7 +1,7 @@
 import { HttpClient, HttpErrorResponse } from "@angular/common/http";
 import { Injectable } from "@angular/core";
 import { DeviceInfo, Device } from "@capacitor/device";
-import { IAppConfig, getProtectedFieldName } from "data-models";
+import { IAppConfig, getProtectedFieldName, EXCLUDED_FIELDS } from "data-models";
 import { interval } from "rxjs";
 import { throwError } from "rxjs";
 import { environment } from "src/environments/environment";
@@ -70,7 +70,9 @@ export class ServerService extends SyncServiceBase {
       this.app_user_id = uuid;
     }
     console.log("[SERVER] sync data");
-    const contact_fields = this.localStorageService.getAll();
+    const all_contact_fields = this.localStorageService.getAll();
+    const contact_fields = this.removeExcludedContactFields(all_contact_fields);
+
     const dynamic_data = await this.dynamicDataService.getState();
 
     // apply temp timestamp to contact fields to sync as latest
@@ -115,6 +117,15 @@ export class ServerService extends SyncServiceBase {
     });
   }
 
+  /** Remove any protected fields that should not be synced */
+  private removeExcludedContactFields(contactFields: {}) {
+    const { prefix } = this.localStorageService;
+    EXCLUDED_FIELDS.forEach(
+      (field) => delete contactFields[`${prefix}.${getProtectedFieldName(field)}`]
+    );
+    return contactFields;
+  }
+
   private handleError(error: HttpErrorResponse) {
     //   sync failed, retry later (?)
     return throwError("Could not connect to server");