[BUG]: a_target_warning should pick up text alternatives to indicate the new window

[tombrunet]

Project

accessibility-checker-engine

Browser

Chrome

Operating system

MacOS

Description

The a_target_warning is looking for indications of a new window in the text or title. If there's an icon with alt text to indicate the new window, that is not detected, so it files a false positive. Note that this is a recommendation, but still should be a straight forward fix.

Steps to reproduce

<a href="#" target="_blank">Some link<img alt="opens in new window" src=""></a>

Note that this should also not fire if the alt text is in an svg (title, aria-label, etc). See Carbon link with icon for example of that structure

[shunguoy]

Triage: the NR shouldn't be reported if the link has an alt, or it's an icon.