This repository has been archived by the owner on Jul 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 13
Minor fix #68
Open
kant
wants to merge
1
commit into
IBM:master
Choose a base branch
from
kant:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Minor fix #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandel
reviewed
Jan 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your feedback but we don't like some of your fixes.
@@ -17,21 +17,22 @@ the directory [docs](./docs). | |||
|
|||
## Quick install with Opam | |||
|
|||
You can install wcs-ocaml with the following command: | |||
You can install `wcs-ocaml` with the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't like this formating. We prefere to keep wcs-ocaml.
@@ -88,7 +89,7 @@ grep -r -e '\d\d\d\d-\d\d-\d\d.\d\d-dev' . | |||
|
|||
3. Update the `CHANGES.md` file. | |||
|
|||
4. Create a new release on the github interface: | |||
4. Create a new release on the Github interface: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be GitHub.
@@ -125,7 +126,7 @@ cp packages/wcs-lib/wcs-lib.XXXX-XX-XX.XX/url packages/wcs/wcs.XXXX-XX-XX.XX/url | |||
``` | |||
git push origin wcs-XXXX-XX-XX.XX | |||
``` | |||
- Create a pull request from the github interface: | |||
- Create a pull request from the Github interface: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idem.
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(proposals)