Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

abstract common functions in ODLM #587

Open
horis233 opened this issue Jan 3, 2021 · 0 comments
Open

abstract common functions in ODLM #587

horis233 opened this issue Jan 3, 2021 · 0 comments

Comments

@horis233
Copy link
Contributor

horis233 commented Jan 3, 2021

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

In the ODLM, there are some duplicate codes for similar functions.
For example:

  • finalizer management
  • status initialization
  • code structuration like createIfNotExists, createOrUpdate and deleteIfExits.

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

We can abstract an ODLM controller for managing common functions like finalizer management #517 and using provided API from controller-runtime https://pkg.go.dev/sigs.k8s.io/[email protected]/pkg/controller/controllerutil for createIfNotExists, createOrUpdate and deleteIfExits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants