Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent resolutions when comparing images lead to padding bug #62

Open
karsten-martin opened this issue Aug 2, 2024 · 0 comments
Assignees

Comments

@karsten-martin
Copy link

description

  • Runs with layout checks do fail with error code like:
    "The actual picture overlaps the expected picture.
    expected size: 1080x2072, actual size: 1080x2138"

  • actual devices resolution is: "1080x2340"

  • Issue was spotted multiple times

affected runs

4063

expected result

When running layout tests with screenshot resembles step, the devices resolution is used, so the expected one here should be "1080x2340". The taken shots will have the same resolution as the test is using, or it is able to compensate via cropping and resizing.

@karsten-martin karsten-martin changed the title Mobile Run with Saucelabs, Mobile Run with Saucelabs fails due to incosistent resolutions Aug 2, 2024
@mario-s mario-s self-assigned this Aug 23, 2024
@derdualist derdualist changed the title Mobile Run with Saucelabs fails due to incosistent resolutions Mobile Run with Saucelabs fails due to inconsistent resolutions Sep 9, 2024
@derdualist derdualist changed the title Mobile Run with Saucelabs fails due to inconsistent resolutions Inconsistent resolutions when comparing images lead to padding bug Nov 8, 2024
derdualist added a commit that referenced this issue Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants