Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

filter: split JsonResource's nested/flattened resource support for testing #144

Open
srl295 opened this issue Apr 22, 2019 · 0 comments
Open

filter: split JsonResource's nested/flattened resource support for testing #144

srl295 opened this issue Apr 22, 2019 · 0 comments

Comments

@srl295
Copy link
Contributor

srl295 commented Apr 22, 2019

  • right now, impl.JsonResource does the mapping between flattened (jsonpath) and unflattened (in the JSON file) format.
  • since the code requires a GP instance, it's harder to test compatibility (such as with gp-js-flatten in Javascript).

Refactor the code to improve testability.

It might be possible to do a general refactor, which would support arbitrary other filters being tested as well, or something specific to JsonResource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@srl295