Validator API returns incorrect line counts for schema and ruleset violations if file uses old Mac-style CR only line endings

[simon-20]

Brief Description
Validator API will return incorrect line counts for schema and ruleset violations if file uses old Mac-style CR only line endings.

The Validator has to manually count lines for violation reporting because it splits up IATI XML activity files by activity, generating a new XML DOM object for each. The code which counts lines just counts LR characters; it is here:

js-validator-api/services/rulesValidator.js

Line 953 in 769bcd5

idx = oneIatiActivity.indexOf(10, idx + 1);

This means line counts will be inaccurate if the file uses any single CR as line endings.

Severity
Low

[simon-20]

Although very few desktop/development systems use CR-only line endings, plenty of files in the IATI corpus have mixed line endings where at least some lines are CR. Such files are valid XML.

[simon-20]

Problem also exists in getLineStart:

js-validator-api/services/rulesValidator.js

Line 828 in 769bcd5

const getLineStart = (xml, subElement) => {