Yellow flags (i.e. future transaction indicators) on timeliness pages are incorrect

[andylolz]

The yellow flags on the timeliness frequency and timelag pages are intended to indicate that a publisher has reported future transactions in the last 12 months. However, that information is not currently shown on the page.

The relevant data stopped recording on the publishingstats server on 2019-07-22 – presumably this was around the time the dashboard and publishing stats were split:
http://publishingstats.iatistandard.org/stats-blacklist/gitaggregate-publisher-dated/drc/activities_with_future_transactions.json

The relevant data is still recorded on the dashboard server, here:
http://dashboard.iatistandard.org/stats-blacklist/gitaggregate-publisher-dated/drc/activities_with_future_transactions.json

There are yellow flags on these dashboard pages, but they’re actually flagging something different. They actually indicate an error with publishingstats (not with the publisher’s data), because the publisher wasn’t found in the future transactions data. That’s because there is no future transaction data for these publishers, because they started after this data stopped being recorded.

So these yellow flags are now just saying “this publisher started publishing after 2019-07-22”.

If you check the data-severity for these yellow flags, it’s actually -1, indicating an error:

IATI-Publishing-Statistics/IATI-Dashboard/timeliness.py

Lines 168 to 174 in edb5b14

	def has_future_transactions(publisher):
	"""
	returns 0, 1 or 2
	Returns 2 if the most recent data for a publisher has future transactions.
	Returns 1 if the publisher has ever had future transactions.
	Returns -1 if the publisher has not been checked for some reason.
	Returns 0 otherwise.

[stevieflow]

Good spot @andylolz

I know of a few publishers that are concerned about these yellow flags. If these are false, then it'd be greatly appreciated to resolve the issue