Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: remove inlineDiv from all instance its used and replace with carbon grid #1027

Closed
wants to merge 2 commits into from
Closed

WIP: remove inlineDiv from all instance its used and replace with carbon grid #1027

wants to merge 2 commits into from

Conversation

Lovelyfin00
Copy link
Contributor

@Lovelyfin00 Lovelyfin00 commented May 1, 2024 •
edited
Loading

Fixes #978

  • The PR title includes a brief description of the work done, including the Issue number if applicable.
  • The PR includes a video showing the changes for the work done.
  • The PR title follows conventional commit label standards.
  • The changes confirm to the OpenElis Global x3 Styleguide and design documentation.
  • The changes include tests or are validated by existing tests.
  • I have read and agree to the Contributing Guidelines of this project.

Summary

This PR is to remove inlineDiv class that is being used in a lot of places and pages on the application and replace with the correct Grid and Column from the carbon design system

  • Removed for modifyOrderPage.js
  • Removed from AddSample.js page

Screenshots

[To be Added]

@github-actions GitHub Actions
Copy link

github-actions bot commented May 7, 2024

👋 Hi, @Lovelyfin00,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict Merge Conflicts label May 7, 2024
@mozzy11 mozzy11 closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merge conflict Merge Conflicts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Carbon Grid for Layout instead of Using custom css classes
2 participants
@Lovelyfin00 @mozzy11