Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Carbon Grid for Layout instead of Using custom css classes #978

Open
mozzy11 opened this issue Apr 12, 2024 · 3 comments
Open

Use Carbon Grid for Layout instead of Using custom css classes #978

mozzy11 opened this issue Apr 12, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mozzy11
Copy link
Collaborator

mozzy11 commented Apr 12, 2024

In some of our form components , we use custom classes for the form Layout ie
we use the inlineDiv class to arange elements in a row inside a form .

     
                    <div className="inlineDiv">
                        <div>
                             <TextInput required name="name" className="InputText"/>
                             <TextInput required name="name" className="InputText"/>
                        </div>
                     </div>
                    <div className="inlineDiv">
                       <div>
                            <TextInput required name="name" className="InputText"/>
                            <TextInput required name="name" className="InputText"/>
                        </div>
                     </div>
             

We can use the Carbon Grid to create the similarLayout which is easier to control responsiveness

                     <Grid>
                  
                            <Column lg={8}>
                                <TextInput required name="name" >                    
                            </Column >
                            <Column lg={8}>
                                <TextInput required name="name"/>
                            </Column >   
 
                           <Column lg={8}>
                               <TextInput required name="name" "/>
                            </Column >  
                             <Column lg={8}>    
                               <TextInput required name="name" >
                             </Column >
         
                      <Grid>
@mozzy11 mozzy11 added the enhancement New feature or request label Apr 12, 2024
@mozzy11 mozzy11 changed the title Use Carbon Grid for Layout instead of Using custom css class Use Carbon Grid for Layout instead of Using custom css classes Apr 12, 2024
@Lovelyfin00
Copy link
Contributor

Hi @mozzy11
I'd like to work on this

@Muta-Jonathan
Copy link

Hello @mozzy11
would like to work on this 👍🏿

@Muta-Jonathan
Copy link

hey @mozzy11 PR here #1268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Under Review
3 participants