-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage for India #634
Comments
thanks for sharing, it is very inline with EU implementation but interestingly leaner (more basic) than EU. are you able to test the library directly if I give you some guidance around executing the library locally on your machine, rather than relying fully on home assistant integration? I am asking this because home assistant integration is consuming the library (https://github.com/Hyundai-Kia-Connect/hyundai_kia_connect_api) and testing on library would be much more faster. |
@fuatakgun absolutely. Thank you for taking a look, currently running HA via RPI. But can run the same locally with your input. please let me know. |
Just checking back @fuatakgun. Please let me know if I can add or contribute further towards this 😊🙏 |
@fuatakgun I am also interested in testing this if it works in India. |
@PrathikGopal , can you please share the logs again? sorry for missing this |
Sent it over to you 😊👍🏽 |
well received |
Great, waiting eagerly 😊👍🏽 |
@fuatakgun, did you get a chance to look at this? Thanks for considering this. I also drive a Kia in India, please let me know if I can help in some way. Thanks a lot for your efforts. |
@fuatakgun still awaiting eagerly 👍 incase you need the logs let me know. |
Library is updated to work with India region in india branch in my repo. https://github.com/gowthamgowtham/hyundai_kia_connect_api. I've tested for a Hyundai vehicle. Not sure if Kia needs any changes, may be the URLs? It was forked couple of months ago. Some cleanup might be necessary. The repo has a executable script |
Could you create a pull request? |
@gowthamgowtham - It would be great if you could please create a pull request for this. Really appreciate your help 🙏 |
Sorry I could not reply sooner. I will get to creating pull request sometime this weekend. Thank you for your patience! Meanwhile, I am just curious to know if anyone in India had any success with this code? |
@gowthamgowtham I can test this for Kia India however cant seem to find the india.py file in your repo?. Any idea |
@sajid2310 heres the file, https://github.com/gowthamgowtham/hyundai_kia_connect_api/blob/india/india.py @gowthamgowtham Will test it later and update. |
doesnt work for KIA, URL is different https://prd.in-ccapi.kia.connected-car.io:8080 Similar to EU |
any updates? |
Are there any updates on this? Will this be merged with master anytime soon? |
@fuatakgun Thanks for your time on this, anyway i could be of help in speeding this up? |
+1 |
I encourage one of you to try take this on. It was close to done here. Hyundai-Kia-Connect/hyundai_kia_connect_api#499 |
Hi! Has anyone got it working, ill be happy to assist, i have a HA and a Kia Carnival. Dont know python but can try and assist to get it working. |
Is your feature request related to a problem? Please describe.
Finally was able to get a trace from the KIA mobile app for INDIA users , have the tracefile and will send it across
Describe the solution you'd like
Add coverage to India users, Have shared the traffic trace file to [email protected] .
Please let me know if you need more information.
The text was updated successfully, but these errors were encountered: