Mobile TODO lista

[thomasgwatson]

Loren:

• Organize and facilitate discussion for Loren, Tom, and maybe Tibet to zoom-out and discuss TailWind / NativeWind and React Native styles to come to coherency and a clear directives about how/what/when/why we want to use each in Mobile.
• Sort-out Hamburger/Back Button UX, and try 2nd level tab stack screens as Full Screen modals. The idea here is to make all 2nd level detail screens full screen modals within the tabs instead of screens on the stack. For example on the Home tab PostDetails, Member, GroupSettingsWebView, and Current Group > Groups? (maybe there are others?) and set them in React Navigation to be full screen modals with the modal header of a X in the left corner instead of screens in the tab stack. This would map to the Web pattern and potentially eliminate the need to manage the hamburger/back-button management in each tab. I think we’re also going to make the Hamburger icon something else, so check back with Aaron and Tibet on that one. Assuming this pattern works and feels right, then make the same changes would be applied to the Messages tab (so a New Message and Thread would open in a full screen modal instead of being on the stack). I think Search opens everything in a modal already. There was a convo between @tibetsprague and I in Next-up: Fixes, Exploring/addressing key UX issues, and code-level tidying-up #292 which may be worth referencing.
• Properly handle context switching via links (e.g. /groups/my-group/my-group-slug)
• URQL: Fix MesageThread subscription flashing/resetting on new message arriving from updates subscription
• URQL: Fix Reaction Deletion for Comment in PostDetails
• @ mentions in editor no longer expand the Editor’s height so in Comment form they are rather dysfunctional
• HyloEditor mobile not allowing setting content (in PostEditor) and not allowing injection of content or reporting isEmpty in CommentEditor chore(web,mobile): Fixes HyloEditorMobile but probably breaks it for Web #354
  Fix Post Editor issues #351
• Image uploading in PostEditor. Currently only takes one out of a multiple selection on iOS at least, which is a new bug
• Post Details shows at bottom of screen when there are not enough comments to push it to the top. Need to switch back to FlatList to employ old hack, or we just embrace the post at the bottom, because it is a sorta a chat after all 😅
• Details when editing a Post is not loading into editor (regression). Also Post type selector is acting weird, and it currently selects “My” as a Group to post to option.

Tom:

• ContextMenu. I want it to look and work better. I want it to indicate what item I’m on, and I think the font size is too small esp. for smaller devices. I want the styling we have on Web with simple rounded boxes instead of the line separators, and no indentation. I have done 2 throw away attempts at re-styling things there and have gotten close but threw out both because there was always something that felt more urgent. I imagine this is true for you as well Tom.
• Still really bothered by not being able to see the names of my groups.
• Move notifications nav/icon down to bottom tab nav

Backlog:

• Notifications icon in TabBar seems to always show a badge even if there are no new notifications. The badge is expected to show with a number of new notifications, or not at all.
• Currently getting Public posts in my My Groups stream while this doesn't seem to be the expected from Web. In general there is some double-checks/diligence to do on Stream querying.
• Look into Public stream for a new user without groups, it seems to not show anything/what is expected. Or maybe it is just that the thing linked to isn’t correct. Not sure.
• Group Welcome for Mobile #355 Do what is needed to get this feature on Mobile: New Group Welcome Page #312. In addition to adding this screen, note changes to routing and queries in that PR and reflect those in the Mobile linking table and shared graphql queries, fragments, and mutations. Please utilize a zustand local store if it needs something like that, and notice the amendments to the Create Group, Group Welcome, and Post Details areas for this emerging pattern. Integrate the UX / code sensibly if there is any overlap with existing GroupWelcome flow.
• Web React Router 6 setup doesn't support navigation blocking, need to refactor setup to support this for Mobile WebViews support: Data Router and useBlocker needed in Web routing to support Mobile WebView navigation handling #358

[thomasgwatson]

@lorenjohnson moved the TODO from slack to here; as this will be easier to refer back to over time.

[thomasgwatson]

Sort-out Hamburger/Back Button UX, and try 2nd level tab stack screens as Full Screen modals. The idea here is to make all 2nd level detail screens full screen modals within the tabs instead of screens on the stack. For example on the Home tab PostDetails, Member, GroupSettingsWebView, and Current Group > Groups? (maybe there are others?) and set them in React Navigation to be full screen modals with the modal header of a X in the left corner instead of screens in the tab stack. This would map to the Web pattern and potentially eliminate the need to manage the hamburger/back-button management in each tab. I think we’re also going to make the Hamburger icon something else, so check back with Aaron and Tibet on that one. Assuming this pattern works and feels right, then make the same changes would be applied to the Messages tab (so a New Message and Thread would open in a full screen modal instead of being on the stack). I think Search opens everything in a modal already. There was a convo between @tibetsprague and I in #292 which may be worth referencing.

Hey @lorenjohnson in this text you reference a Tibet convo but I can't find it such a convo via the link you shared there.

I will take a crack at the back-button/hamburger combo; based on you saying '... modals within the tabs instead of screens' I'm going to assume that those 2nd level screens will still stay in the HomeNavigator, instead of moved to where a bunch of the other modals are living in the navigation

[lorenjohnson]

Unfortunately Modals shouldn't be defined within a TabsNavigator but high up the stack. See https://reactnavigation.org/docs/modal/#best-practices

[thomasgwatson]

Easy. I had a vague recollection of that but wasn't sure, so wanted to make sure I was understanding you correctly

[tibetsprague]

@thomasgwatson I think the conversation we had was just about how the hamburger menu icon has changed to a back button icon in the mobile web, because we that paradigm makes a little more sense. You enter a view, then go back to the nav/context menu. Do you think that paradigm will work well in the app too?

[thomasgwatson]

Once we pop those 2nd level screens into modals, yet, the change of icon makes sense (the modalification will already get us the correct nav behavior)

[thomasgwatson]

Tracking a few little things from the ModalScreening of some routes:

• Group Detail is referenced in a route but doesn't seem to exist. So we are missing an /about or external group details screen. Would be a good modal option
• There is MemberProfile and MemberDetails. They are both ways to render a user but I don't get why we use one over another
• Group Explore (not Explorer) has been dropped. We still have a few navigation catches for it on webviews; safe to remove? Not removing for now

[tibetsprague]

I just realized that the explore page is the only way to see certain farm details 😬 so im wondering if we need to keep it around for now? I mean I dont know if there are any truly active farms. but also might be noticed by open team folks or others, and we may need to bring it back. is it easy to just leave the route and page working? though actually I think we show the important stuff on the group detail/about page, which I think need some kind of working version of on mobile.

[thomasgwatson]

OK, so Group Explore is still intact on mobile. The obvious missing thing is a common view widget to point at it. So if that is introduced, and widgetUrl/makeWidgetUrl forms the correct url for it on web/mobile, it will be happy.

I think we are still missing a /groups/:groupSlug/about

[thomasgwatson]

Did you pull the cog for group settings from the context menu header? I should have caught that in the review; its still needed. I can add it back

[lorenjohnson]

should still be there

[hylobot]

Ahhh probably that user is not admin, sorry

…

On Tue, Mar 4, 2025, 18:38 'Loren Johnson' via Developers ***@***.***> wrote: should still be there — Reply to this email directly, view it on GitHub <#323 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACM5E5Z3CHC4W56BONNIAPL2SVKARAVCNFSM6AAAAABYDXHUXSVHI2DSMVQWIX3LMV43URDJONRXK43TNFXW4Q3PNVWWK3TUHMYTEMZYGQ4DSNY> . You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>