Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement verification for Halo2 ZK proofs #27

Closed
wraitii opened this issue May 22, 2024 · 8 comments
Closed

Implement verification for Halo2 ZK proofs #27

wraitii opened this issue May 22, 2024 · 8 comments
Assignees
Labels
ODHack Onlydust Hackathon

Comments

@wraitii
Copy link
Member

wraitii commented May 22, 2024

The purpose of this issue is to implement verification of Halo2 proofs on Hylé.

This should be done using a subprocess call a rust verifier, similar to our risczero implementation.
See instructions on https://github.com/axiom-crypto/halo2-scaffold/ for integration

Additionally, the matching verifier must be implemented in the verifier repository → Hyle-org/verifiers-for-hyle#11

This PR is related to the “WebAuthn signer support” PR → Hyle-org/webauthn-identity-provider#1

@RajeshRk18
Copy link

Shall I take up this?

@wraitii
Copy link
Member Author

wraitii commented May 29, 2024

Shall I take up this?

If you're still up for this, go ahead :)

@RajeshRk18
Copy link

RajeshRk18 commented May 29, 2024

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

@wraitii
Copy link
Member Author

wraitii commented May 30, 2024

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

In principle we want a general verifier - you should take a Verification Key (or similar) and a proof and output whether the proof is correct or not.

@RajeshRk18
Copy link

@wraitii Is the prover and verifier for P256 sig? Like I need to write verifier circuit for it?

In principle we want a general verifier - you should take a Verification Key (or similar) and a proof and output whether the proof is correct or not.

Like in the axiom's halo2 scaffold right?

Here is how it will look like;

  • A separate repo for halo2 prover
  • A verifier in the verifier repo

@wraitii
Copy link
Member Author

wraitii commented May 30, 2024

Like in the axiom's halo2 scaffold right?

  • A separate repo for halo2 prover
  • A verifier in the verifier repo

Most likely, not really familiar with the axiom scaffold.
We don't per-se need a prover, but an example application would be good.

@guha-rahul
Copy link

Can i work on this?

@wraitii
Copy link
Member Author

wraitii commented Jun 24, 2024

Can i work on this?

Hey @guha-rahul , I've assigned you. Don't hesitate to ask question on Telegram if there's any issue: https://t.me/+ziFJlAUfPlU1NzRk

@s0lness s0lness assigned s0lness and guha-rahul and unassigned s0lness Jun 24, 2024
@wraitii wraitii closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ODHack Onlydust Hackathon
Projects
None yet
Development

No branches or pull requests

4 participants