Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log less information via AdvantageKit and leverage hoot files #77

Open
gcschmit opened this issue Jan 5, 2024 · 0 comments
Open

log less information via AdvantageKit and leverage hoot files #77

gcschmit opened this issue Jan 5, 2024 · 0 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@gcschmit
Copy link
Contributor

gcschmit commented Jan 5, 2024

Phoenix 6 now logs all signals to hoot files along with the CAN timestamp. AdvantageScope now supports downloading and importing hoot files. This is a more complete and more precise logging of signals than we can do. As a result, we should log fewer signals in our subsystems in order to improve periodic performance. We can import the hoot file for more detailed analysis when needed. However, since downloading and importing the hoot file is an extra step, we still want to log those signals that we expect to need often.

Before we start removing members from our IO classes, we should test that AdvantageScope's support of hoot files works as we expect.

@gcschmit gcschmit added enhancement New feature or request help wanted Extra attention is needed labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

1 participant