Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth flow breaks when using cloud IDEs #262

Open
jsines opened this issue Feb 5, 2024 · 0 comments
Open

Auth flow breaks when using cloud IDEs #262

jsines opened this issue Feb 5, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@jsines
Copy link
Contributor

jsines commented Feb 5, 2024

Describe the bug

Reported in slack

Noticed a flow issue for using the VS Code extension which uses the CLI, specific to cloud IDEs.
If you use github code spaces or gitpod, and probably any other online IDE the VS Code extensions authenticate button sends you to the personal access key screen which is great, but then that page tries to automatically launch vs code and enter the auth. Cool feature except if you use a cloud version because it then doesn't give you a path to authenticate other than to install the CLI and manually do it in the terminal. The issue is that if you didn't know that was how you authed, you'd just assume it wasn't going to work for you and that it might be broken.
Suggested fix is if we're using like a query parameter or something to prompt that VS code launching, we should display a modal or on screen prompt of some kind to the user giving them a choice, to auth by launching local vs code or by pasting the key or something.

Auth is handled in: https://github.com/HubSpot/hubspot-cms-vscode/blob/master/src/lib/commands/auth.ts

@jsines jsines added the bug Something isn't working label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant