From bbda183f6379c90516146ecc43211e039418ce2c Mon Sep 17 00:00:00 2001
From: Carlo Cabrera <30379873+carlocab@users.noreply.github.com>
Date: Tue, 15 Aug 2023 10:09:42 +0800
Subject: [PATCH] workflows: fix bottle uploads for replacement PRs

The empty string is falsey in JavaScript, so `--no-upload` is always
interpolated in the call to `brew pr-pull`. Let's fix that so that
`--no-upload` is passed only when the replacement PR is requested
without a bottle upload.
---
 .github/workflows/create-replacement-pr.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/create-replacement-pr.yml b/.github/workflows/create-replacement-pr.yml
index 881d17ac2664..93683dfce044 100644
--- a/.github/workflows/create-replacement-pr.yml
+++ b/.github/workflows/create-replacement-pr.yml
@@ -154,7 +154,7 @@ jobs:
             --committer="$BREWTESTBOT_NAME_EMAIL" \
             --root-url="https://ghcr.io/v2/homebrew/core" \
             ${{ inputs.autosquash && '--autosquash' || '--clean --no-cherry-pick' }} \
-            ${{ inputs.upload && '' || '--no-upload' }} \
+            ${{ !inputs.upload && '--no-upload' || '' }} \
             ${{ inputs.warn_on_upload_failure && '--warn-on-upload-failure' || '' }} \
             ${{ inputs.message && '--message="$MESSAGE"' || '' }} \
             "$PR"