Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanmymac: various updates #177307

Merged
merged 1 commit into from
Jun 20, 2024
Merged

cleanmymac: various updates #177307

merged 1 commit into from
Jun 20, 2024

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-cask-pr.

@BrewTestBot BrewTestBot added the bump-cask-pr PR was created using `brew bump-cask-pr` label Jun 20, 2024
@BrewTestBot BrewTestBot enabled auto-merge June 20, 2024 09:35
@khipp
Copy link
Member

khipp commented Jun 20, 2024

Apart from the major version, the download for this cask is pretty much unversioned. Should the checksum be removed to prevent mismatches between upstream updates and version bumps?

@bevanjkay
Copy link
Member

Yes it should be :no_check as it currently stands.

We should be able to use the fully qualified versioned url - https://dl.devmate.com/com.macpaw.CleanMyMac4/41504.0.2406170832/1718790632/CleanMyMacX-41504.0.2406170832.zip
But will require a rework of the livecheck and version too.

@bevanjkay bevanjkay marked this pull request as draft June 20, 2024 10:27
auto-merge was automatically disabled June 20, 2024 10:27

Pull request was converted to draft

@bevanjkay bevanjkay force-pushed the bump-cleanmymac-4.15.4 branch from 14e010d to 503ccfb Compare June 20, 2024 10:33
@bevanjkay bevanjkay changed the title cleanmymac 4.15.4 cleanmymac: various updates Jun 20, 2024
@bevanjkay bevanjkay marked this pull request as ready for review June 20, 2024 10:34
@BrewTestBot BrewTestBot enabled auto-merge June 20, 2024 10:34
@BrewTestBot BrewTestBot merged commit 4e3906e into master Jun 20, 2024
11 checks passed
@BrewTestBot BrewTestBot deleted the bump-cleanmymac-4.15.4 branch June 20, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-cask-pr PR was created using `brew bump-cask-pr`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants