-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fonts: remove all desc
stanzas
#176580
fonts: remove all desc
stanzas
#176580
Conversation
I would argue the opposite: for consistency all casks should have a description including fonts. I don't really see a benefit in fonts not having one. |
Descriptions aren't often useful for fonts would be my additional thought here. "Geometric sans-serif font" - doesn't say much. I don't know if it matters that some have descriptions and some don't though. |
I'm fine with removing these for the reasons stated above. |
Thank you @p-linnane. |
Would like to make after-the-fact arguments for reverting this: It feels much nicer to have descriptions on some fonts rather than none. If a description for a given font isn't useful: it does no harm. Removing, at least in my case, several useful descriptions feels like consistency for consistency's sake and does not make things better for users.
I agree with this. It'd be nice to reinstate these descriptions by reverting this PR, requiring descriptions on all new fonts and making a |
Since we do not require a
desc
stanza for fonts, and in the spirit of consistency, I propose we remove them all.See #174976 for more context.
Note that there are currently 2,265 font Casks, and only these 585 currently have a
desc
stanza.