Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fonts: remove all desc stanzas #176580

Merged
merged 1 commit into from
Jun 13, 2024
Merged

fonts: remove all desc stanzas #176580

merged 1 commit into from
Jun 13, 2024

Conversation

miccal
Copy link
Member

@miccal miccal commented Jun 13, 2024

Since we do not require a desc stanza for fonts, and in the spirit of consistency, I propose we remove them all.

See #174976 for more context.

Note that there are currently 2,265 font Casks, and only these 585 currently have a desc stanza.

@miccal miccal added the ci-syntax-only Only run syntax checks on CI. Use only for bulk changes. label Jun 13, 2024
@miccal miccal changed the title fonts: remove all desc stanzas fonts: remove all desc stanzas Jun 13, 2024
@SMillerDev
Copy link
Member

I would argue the opposite: for consistency all casks should have a description including fonts.

I don't really see a benefit in fonts not having one.

@bevanjkay
Copy link
Member

bevanjkay commented Jun 13, 2024

Descriptions aren't often useful for fonts would be my additional thought here.

"Geometric sans-serif font" - doesn't say much.
Outside of these kind of descriptions it's mainly marketing blah blah.

I don't know if it matters that some have descriptions and some don't though.

@p-linnane
Copy link
Member

I'm fine with removing these for the reasons stated above.

@miccal
Copy link
Member Author

miccal commented Jun 13, 2024

Thank you @p-linnane.

@miccal miccal merged commit b513627 into Homebrew:master Jun 13, 2024
7 checks passed
@miccal miccal deleted the remove-desc-fonts branch June 13, 2024 15:01
@miccal miccal mentioned this pull request Jun 15, 2024
9 tasks
@MikeMcQuaid
Copy link
Member

Would like to make after-the-fact arguments for reverting this:

It feels much nicer to have descriptions on some fonts rather than none. If a description for a given font isn't useful: it does no harm. Removing, at least in my case, several useful descriptions feels like consistency for consistency's sake and does not make things better for users.

I would argue the opposite: for consistency all casks should have a description including fonts.

I don't really see a benefit in fonts not having one.

I agree with this. It'd be nice to reinstate these descriptions by reverting this PR, requiring descriptions on all new fonts and making a help wanted issue to add them to existing font casks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip ci-syntax-only Only run syntax checks on CI. Use only for bulk changes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants