Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit logi-options-plus-minimal #172612

Closed
wants to merge 2 commits into from
Closed

Submit logi-options-plus-minimal #172612

wants to merge 2 commits into from

Conversation

ezrayellin
Copy link

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused.
  • Checked the cask is submitted to the correct repo.
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Background

I used the name minimal instead of offline since there are still some networking features enabled in the "offline" version.

@bevanjkay
Copy link
Member

Regarding the token, I think going with logi-options-plus-offline makes more sense, as that it what it is called by the vendor.
Whether or not this is suitable to be included in homebrew-cask, I'm not sure, it may be better suited to a personal tap, as it is maybe a bit too niche.

Strangely, the FAQ for this version provides conflicting information about the feature set. So I do wonder if it will remain this way long-term.

Screenshot 2024-05-01 at 11 15 36 am

Screenshot 2024-05-01 at 11 15 41 am

Logitech Options+ without the bloatware
`minimal` -> `offline`
@ezrayellin
Copy link
Author

Regarding the token, I think going with logi-options-plus-offline makes more sense, as that it what it is called by the vendor.

Updated.

@ezrayellin
Copy link
Author

Strangely, the FAQ for this version provides conflicting information about the feature set. So I do wonder if it will remain this way long-term.

Some of those features can be disabled with arguments to the installer, so behavior could be maintained in the future.

@ezrayellin
Copy link
Author

I'm not sure, it may be better suited to a personal tap, as it is maybe a bit too niche.

I have created a personal tap with my preferred settings for the cask. I'll close the pull request, it can be re-opened if desired.

@ezrayellin ezrayellin closed this May 1, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants