-
-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fetch for Intel Sequoia #19079
base: master
Are you sure you want to change the base?
Fix fetch for Intel Sequoia #19079
Conversation
de0d340
to
0582f6f
Compare
Thanks for taking a look at this. I don't think the current solution of using It sounds like ideally we'd have some way to realize that an intel-sequoia bottle doesn't exist and that the sonoma bottle would be used instead. Then, maybe we could display that as a warning to the user. |
Agreed. The logic in
No need to warn for this given we don't warn for |
One thing is that fallback would occur if Currently, brew(main):001> Formula["qt"].bottled?(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm))
=> false
brew(main):002> Formula["qt"].bottled?(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64))
=> true
brew(main):003> Formula["qt"].bottle_for_tag(Utils::Bottles::Tag.new(system: :sequoia, arch: :arm64)).tag
=> #<Utils::Bottles::Tag:0x000000012a8db8c0 @arch=:arm64, @system=:sonoma, @to_macos_version=#<MacOSVersion: "14">> brew/Library/Homebrew/extend/os/mac/utils/bottles.rb Lines 49 to 52 in 4c9de7d
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
@muneebmahmed Would still like this PR but needs a tweaked approach! |
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?Fixes #19060. On Intel Sequoia,
brew install
install from Sonoma bottles as expected, butbrew fetch
gives errors due to lack of asequoia:
bottle. I'm not sure how exactly the formula installer resolves the bottle tag, but I just took a look at the function that's called and copied it over to the fetch command, and it worked:brew/Library/Homebrew/formula_installer.rb
Line 218 in 1e91082