Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

formula_creator: move initial CLI values into constructor #16260

Merged
merged 19 commits into from
Nov 30, 2023

Conversation

abitrolly
Copy link
Contributor

@abitrolly abitrolly commented Nov 27, 2023

Sets initial values for formula fields from CLI params.

Another refactoring for code clarity to keep #16238 minimal.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@abitrolly abitrolly changed the title formula_creator: move initial values CLI into constructor formula_creator: move initial CLI values into constructor Nov 27, 2023
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Looking good so far. Some suggested extensions.

Library/Homebrew/dev-cmd/create.rb Outdated Show resolved Hide resolved
Library/Homebrew/dev-cmd/create.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Liking the progress, nice work!

Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
@abitrolly
Copy link
Contributor Author

@MikeMcQuaid should be good now.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @abitrolly, really great work here. Think we're almost there 🤞🏻

Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
Library/Homebrew/formula_creator.rb Show resolved Hide resolved
Library/Homebrew/formula_creator.rb Outdated Show resolved Hide resolved
@abitrolly
Copy link
Contributor Author

@MikeMcQuaid done.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work again, thanks @abitrolly!

@MikeMcQuaid MikeMcQuaid merged commit 3f841cb into Homebrew:master Nov 30, 2023
27 checks passed
@abitrolly abitrolly deleted the formula-constructor branch November 30, 2023 20:48
@github-actions github-actions bot added the outdated PR was locked due to age label Dec 31, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants