-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
formula_creator: move initial CLI values into constructor #16260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. Looking good so far. Some suggested extensions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Liking the progress, nice work!
@MikeMcQuaid should be good now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again @abitrolly, really great work here. Think we're almost there 🤞🏻
@MikeMcQuaid done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work again, thanks @abitrolly!
Sets initial values for formula fields from CLI params.
Another refactoring for code clarity to keep #16238 minimal.
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?