-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create component "Filter by Volumes" #293
Comments
Please see comments 2-7 from #284 (comment). |
@plutonik-a is preparing a version with a truncated volume title as a temporary measure, awaiting decision how to present long titles for the sidebar |
* wrap volume inputs into seperate form & add accessible form and list markup for inputs * serialize parameters for volumes
Status: The (multilined) volume titles are truncated to one line and their width depends on the width of the wrapping parent element. So in medium sized screens, the lines expand to full width, otherwise are limited in a sidebar. |
using @joewiz's suggestion for truncating the titles in sidebar: medium sized screen: |
Thanks, Magda! That is our best option with the titles. The series is weird and inconsistent in its naming and numbering of volumes, and there’s only so much we can do. |
Thanks for confirmation @joewiz. As I see it we have potentially two more related things:
Please, confirm if 1. is the desired solution, if so let's open a new issue and we will proceed with implementing it, though it will have low priority until we are done with core advanced search features. |
* feat-date-search: fix(search): Fix conditional display of date section #288 fix(search): Refactor date and time input IDs #288 feat(volumes filter) trim volume names down to subseries+volume_number+volume titles; affects #293 fix(date filter) remove redundant date criteria serialization; affects #288 feat(date filter) aggregate partial date controls (mm dd yyyy) into single query param and back; addresses #288 feat(date search) first take on date search fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section fix(date filter) add templating relaed attributes and fix names; affects #288 feat(date search) first take on date search feat(date search) first take on date search feat(date filter) aggregate partial date controls (mm dd yyyy) into single query param and back; addresses #288 fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section fix(date filter) add templating relaed attributes and fix names; affects #288 feat(date search) first take on date search feat(date search) first take on date search fix(filters) bring back checking of volumes/administrations etc, add templating attributes for date section fix(date filter) add templating relaed attributes and fix names; affects #288 feat(date search) first take on date search feat(date search) first take on date search feat(date search) first take on date search
@joewiz confirms that limiting the number of volumes initially shown and making the rest available via 'more volumes` button is a good idea, I will follow up creating an issue |
Display "Filter by volumes" in the result page. First 3 options are shown, the rest ist hidden and will be expanded by clicking the "show more" link.
Most volumes have long titles, that can hardly be displayed in a sidebar.
See comment #284 (comment)
Awaiting an answer from @joewiz about the concept.
Updates: (from Joe in #284 (comment))
The first few results of this query are:
Parent: #284
Dependent on: #287
The text was updated successfully, but these errors were encountered: