Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create component "Filter Administration" #292

Open
plutonik-a opened this issue Nov 13, 2017 · 6 comments
Open

Create component "Filter Administration" #292

plutonik-a opened this issue Nov 13, 2017 · 6 comments
Assignees
@tuurma
Labels
low priority
Milestone
2.1 FRUS Advanced...

Comments

@plutonik-a
Copy link
Contributor

plutonik-a commented Nov 13, 2017 •
edited
Loading

Display "Filter by administrations" in the result page. First 3 options are shown, the rest ist hidden and will be expanded by clicking the "show more" link.

bildschirmfoto 2017-11-13 um 14 16 04

Update: from #284 (comment)

  • No dropdown indicators for this component
  • Text-color should be default text-color instead of link-color
  • Display amount of hits next to the option
  • "More Administrations" instead of "Show more"

Parent: #284
Dependent on: #287
@plutonik-a plutonik-a added this to the 2.1 FRUS Advanced search milestone Nov 13, 2017
@plutonik-a plutonik-a mentioned this issue Nov 13, 2017
Open
11 tasks
@joewiz
Copy link
Member

joewiz commented Nov 13, 2017

Please see comments 2-7 from #284 (comment).

@joewiz
Copy link
Member

joewiz commented Nov 14, 2017

@plutonik-a Just to be clear, the Administrations filter will just show a flat list of administrations, not a nested list of volumes in each administration as in the sample code that you just pasted in here. The volumes now have their own separate filter.

@plutonik-a
Copy link
Contributor Author

@joewiz Ok, thanks for pointing this out. I will delete the comment.

plutonik-a added a commit that referenced this issue Nov 22, 2017
@plutonik-a
feat(search): Parameterize administrations filters #292
e5a5efb 
* create include for administrations filters
* delete hard coded filters from template
tuurma added a commit that referenced this issue Nov 24, 2017
@tuurma
refactor: modularize filter checklists; affects #284, #292
87de4ad
plutonik-a added a commit that referenced this issue Nov 24, 2017
@plutonik-a
feat(search): wrap component forms into section element #286 #292
00fcd41
plutonik-a added a commit that referenced this issue Nov 24, 2017
@plutonik-a
Merge branch 'feat-advanced-search-284' of https://github.com/History…
19b02f8 
…AtState/hsg-shell into feat-advanced-search-284

* 'feat-advanced-search-284' of https://github.com/HistoryAtState/hsg-shell:
  refactor(search) further parametrize checkbox templates
  fix(search) add correct template call to search landing page
  refactor: modularize filter checklists; affects #284, #292
@tuurma
Copy link
Contributor

tuurma commented Nov 29, 2017

@plutonik-a please check again the parameters, I will take over afterwards and implement the filter on the backend

@tuurma tuurma self-assigned this Nov 29, 2017
plutonik-a added a commit that referenced this issue Nov 29, 2017
@plutonik-a
fix(search): Fix serialization of administrations #292
0b9b0eb 
Serialize administration inputs and add divider before query parameter
@tuurma
Copy link
Contributor

tuurma commented Nov 30, 2017

Information about volume being part of administration grouping is stored in
collection(" /db/apps/frus/bibliography")//volume[@id={VOLUME}]/administration

@plutonik-a
Copy link
Contributor Author

Status: The UI is completely implemented, search parameters are correctly passed on.

Template: pages/search/_filter-administrations.html
(already implemented but commented-out in pages/search/search-result.html)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tuurma tuurma

Labels
low priority
Projects
None yet
Milestone
2.1 FRUS Advanced search
Development

No branches or pull requests
3 participants
@joewiz @tuurma @plutonik-a