Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Bluesky showcase component and update docs #18

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

trueberryless
Copy link

@HiDeoo I just created the basic changes, if you want custom styling for the Bluesky posts, you're of course free to add them to packages/starlight-showcases/components/ShowcaseBlueskyCard.astro

Copy link

changeset-bot bot commented Feb 17, 2025

🦋 Changeset detected

Latest commit: 8413925

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
starlight-showcases Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starlight-showcases ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 7:34pm

Copy link
Owner

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution 🙌

I just created the basic changes, if you want custom styling for the Bluesky posts

Indeed, blocking for now as the aim is definitely to have some consistency between components, even more in this case between the Twitter component and the Bluesky component.

As-is, the PR just import and render the default implementation provided by astro-embed which by default uses a totally different style compared to the other components provided by the library.

Note that if someone is visiting this PR before this is handled and shipped, and are happy with the current look and feel, just using https://astro-embed.netlify.app/components/bluesky/ directly would provide the same result.

@trueberryless
Copy link
Author

Indeed, blocking for now as the aim is definitely to have some consistency between components, even more in this case between the Twitter component and the Bluesky component.

That's exactly what I thought, I was just too lazy 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluesky
2 participants