Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Кнопка смены пароля выглядит как текст #755

Closed
Yawerica opened this issue Jun 11, 2024 · 5 comments · Fixed by #763
Closed

Кнопка смены пароля выглядит как текст #755

Yawerica opened this issue Jun 11, 2024 · 5 comments · Fixed by #763
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Yawerica
Copy link

Summary

Кнопка не выделяется, не имеет фона
Не очевидно что нужно нажать на неё

Reproduction steps

precondition:
1. Иметь аккаунт на сайте Hexlet.CV

steps:
1. Перейти на страницу авторизации https://cv.hexlet.io/ru/users/sign_in
2. Кликнуть по кнопке Забыли пароль
3. Ввести email. Нажать на кнопку Выслать новый пароль
4. Перейти по ссылке, которая пришла на почту

Expected result

1.предлагаю оформить кнопку как и остальные кнопки на сайте

пожелание к виду кнопки

Actual result

кнопка сменить пароль не видна

Browsers

Chrome

OS

Windows
@Yawerica Yawerica added the bug Something isn't working label Jun 11, 2024
@polina-belyakaeva
Copy link

Hi! I take this issue to work.

@fey
Copy link
Collaborator

fey commented Jul 29, 2024

@polina-belyakaeva Be careful here, Hexlet-CV does not have a dedicated SPA, so changes may need to be made to the templates on slim

@fey fey added the good first issue Good for newcomers label Jul 29, 2024
@polina-belyakaeva
Copy link

@fey thank you! I'll will pay attention to this

fey added a commit that referenced this issue Aug 6, 2024
@fey
Merge pull request #763 from polina-belyakaeva/fix-button-style-for-p…
746cadf 
…assword-recovery

fix confirm password button #755
@fey fey linked a pull request Aug 6, 2024 that will close this issue
fix confirm password button #755 #763
Merged
@fey
Copy link
Collaborator

fey commented Aug 6, 2024

@Yawerica fix deployed, pls review changes

@fey fey moved this to 👀 In review in Hexlet-CV Aug 6, 2024
@Yawerica
Copy link
Author

image

bug fixed. thanks for the work

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Hexlet-CV Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Hexlet-CV
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix confirm password button #755 polina-belyakaeva/hexlet-cv
3 participants
@fey @polina-belyakaeva @Yawerica