Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adtraction link blocking text change #4299

Open
threeoh6000 opened this issue Jan 24, 2025 · 2 comments
Open

Adtraction link blocking text change #4299

threeoh6000 opened this issue Jan 24, 2025 · 2 comments
Labels
feature-request New feature needs to be implemented.

Comments

@threeoh6000
Copy link

threeoh6000 commented Jan 24, 2025

Problem description

Image

The text in the Adtraction is blocked dialogue makes it sound like Heroic is actively adding a link prior to feeding to GOG that injects tracking somehow a la PayPal's Honey extension. From what I've seen in GitHub issues, this appears to be a GOG commission referral scheme though.

Feature description

Changing the text in this dialogue to clarify that this is a partner link and not random spyware injected by Heroic.

Alternatives

Removing the link entirely is an option granted it may be unfair considering its to fund the project or giving the user the option upon first startup to enable or disable the link and making it absolutely clear this is what you are doing as I didn't know this was something Heroic did until installing a Pi Hole and I consider it an anti-feature that this isn't immediately clear to users upon first trying the software.

Additional information

@threeoh6000 threeoh6000 added the feature-request New feature needs to be implemented. label Jan 24, 2025
@imLinguin
Copy link
Member

It is a GOG commission thing, that's how they operate on referral links. My understanding when creating this dialog was that the second sentence With adtraction, any purchase you make in the GOG store supports Heroic financially implies this is a partnership with GOG type of deal.
We are open to suggestions on how to phrase this better

@threeoh6000
Copy link
Author

threeoh6000 commented Jan 24, 2025

I think a good way to rephrase this would be something along the lines of Adtraction is a partner with GOG that supports Heroic financially through a referral commission, something that explicitly points out within the app it is a referral/affiliate link from GOG would be much clearer especially to those who have trouble with implied meaning e.g. non-native English speakers and neurodivergent people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature needs to be implemented.
Projects
None yet
Development

No branches or pull requests

2 participants