-
-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically Detected Cloud Save Path Has Status Message Added to It #4087
Comments
Seems related to umu |
was this an UMU issue? can we close this issue? I understand it was fixed in the UMU side |
I use the Heroic Flatpak and have enabled UMU. I am seeing the same bug there. It's still an issue. I see that the patch was merged 2 months ago into UMU. I guess the Heroic Flatpak has to be updated to a newer version that bundles a newer UMU? @arielj @imLinguin |
This should be fixed with the release of umu 1.1.4. Heroic should use that already. Can you confirm that @Arcitec ? |
@arielj Yes it's broken. :/ See the last line.
Ever since my first message I've been on the latest Heroic Flatpak and UMU has been enabled and I am using Proton-GE-latest: |
I downloaded and unzipped 1.1.4 and checked something:
It seems like the bug is that Heroic Launcher never updates UMU itself. (Edit: Tracking at #4274) |
I just did a test where I erased the old
Edit: And yes this was confirmed now to be UMU 1.1.4 so the UMU bug is not fixed.
So there are two bugs:
|
No, the bug "Command exited with status: 0" was fixed on the umu-launcher side a while ago, but it’ll only apply in certain conditions. To be clear, the offending file is umu-shim where the echo command had redirected its input to stdout after the subprocess that runs your game had exited. But the fix that was addressed in 1.1.4 only becomes applicable once the umu-shim file gets updated or restored. So what you can do right now is either delete everything in $HOME/.local/share/umu or simply delete umu-shim within $HOME/.local/share/umu. In either of those cases, you’ll get the fix. |
@R1kaB3rN There is nothing like that in the Heroic Flatpak. Every UMU-related file and directory was either empty already (checked with Is there anything else I should look for? I did a case-insensitive search for the word "umu" anywhere in all file and dir names:
There's also these files but they are part of the Proton-GE runtime so I think they are irrelevant: Proton-GE files
|
@R1kaB3rN Ahhhhh, I just saw the
It's working. Thank you! So UMU 1.1.4 did fix it, but the bugs are the following two bugs:
|
umu not updating its file in ~/.local/share/umu after Heroic updates its own copy to a new version is expected and is not a bug. Nor will that be planned. To reiterate, its files will only be updated on runtime update or restore. However, getting rid of the helper umu-shim will be considered. Furthermore umu-launcher can instead expose an environment variable(s) that will trigger restoring its files to a clean state or checking the integrity of its files. It would not only solve this issue, but also facilitate debugging because a corrupted runtime can also be the cause of a problem. Such a feature would also enable users to fix problems themselves whenever it's suspected that there are corrupted files. Heroic will just need to expose the feature as a button. Though, this issue actually highlights another one: HGL users can't do anything to reset its private copy of umu from the UI. Otherwise, you or any other user wouldn't need to drop to the terminal to force HGL to redownload it. |
Describe the bug
I recently started using umu-launcher and proton-ge so I'm not sure if that's what's causing this issue as I didn't notice it before. The auto detected save path for any game now contains this appended to the end of the path:
"Command exited with status: 0"
.For example, with Silent Hill 4 (from GOG):
"Prefixes/default/Silent Hill 4 The Room/pfx/dosdevices/v:/Games/Heroic/Silent Hill 4/saveCommand exited with status: 0"
I've had it with other games as well.
More info: Fedora Workstation 40, Heroic Launcher installed using the latest .rpm file from github. Latest umu-launcher installed using their .rpm file for Fedora 40. Proton-GE 9-16. I'm not sure which log I'm supposed to use, so i used both the one for Heroic and the one from the game itself.
Add logs
Steps to reproduce
Expected behavior
This
"Command exited with status: 0."
should not be appended to the automatically detected save file path for every game.
Screenshots
Heroic Version
Latest Stable
System Information
Additional information
No response
The text was updated successfully, but these errors were encountered: